feat(lark-shared): document relative-path-only file arguments#1319
Conversation
Change-Id: I33692186481670dcf7baeaf0a5b5cff2fb18dce9
📝 WalkthroughWalkthroughThis PR adds a single line to the skill documentation clarifying a file path safety constraint. The change specifies that file and output path parameters must use relative paths relative to the current working directory, with absolute paths triggering an ChangesFile Path Safety Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@6f5acd539581086a37cc2dacf8bc6df2ef278172🧩 Skill updatenpx skills add GeekyMax/cli#feat/lark-shared-path -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 685 685
Lines 65770 65770
=======================================
Hits 46793 46793
Misses 15326 15326
Partials 3651 3651 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
lark-cli rejects absolute file paths for path arguments with an
unsafe file patherror, but the lark-shared skill never documented this constraint, so agents repeatedly hit it. This adds a one-line rule under the shared security section so every domain skill inherits the guidance.Changes
安全规则section inskills/lark-shared/SKILL.md, covering--file/--output/--output-dir/@fileand steering large/data input to stdinTest Plan
make unit-test— docs-only change, no Go code touchedskills/lark-shared/SKILL.md— new bullet sits at the end of## 安全规则, no structural/frontmatter changeRelated Issues
N/A
Summary by CodeRabbit