docs(mail): trim lark-mail skill context - #1410
Conversation
📝 WalkthroughWalkthroughUpdated mail skill documentation to consolidate and refine user guidance. Changed skill scope description to be explicit about mail-only usage, made pre-read requirements conditional, emphasized ChangesMail Skill Documentation Refinement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 72.83% 72.83% -0.01%
==========================================
Files 731 732 +1
Lines 69111 69140 +29
==========================================
+ Hits 50335 50356 +21
- Misses 14999 15003 +4
- Partials 3777 3781 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@23e92418a3258f3a2c69ebef576ef9f0e4cca26e🧩 Skill updatenpx skills add bubbmon233/cli#docs/mail-skill-token-trim -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Line 390: The current sentence about using “--yes” reads like an unconditional
bypass; reword the line about only using real `label_id` / `rule_id` and the
`--yes` flag to explicitly state that `--yes` represents explicit user consent
and is only permitted when the user issues the full create→verify→delete
workflow in the same CLI invocation; otherwise the delete step must remain
confirmation-gated (i.e., require an interactive confirmation or separate
explicit delete command), and keep the requirement that only real
`label_id`/`rule_id` may be used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
|
||
| ### 收信规则速查:主题包含文本 → 添加标签 | ||
|
|
||
| 只用真实 `label_id` / `rule_id`,不要猜。用户在同一请求中要求创建、验证、删除规则时,视为本流程已授权,可使用 `--yes` 通过 CLI 确认门。 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Search for other --yes usage patterns and confirmation bypass logic
# Search for --yes flag usage in documentation
rg -n --type=md -C3 '\-\-yes'
# Search for confirmation bypass or authorization skip patterns
rg -n --type=md -C3 '(bypass|skip|绕过|跳过).*(confirm|授权)'Repository: larksuite/cli
Length of output: 50371
Clarify that the --yes usage at line 390 is explicit user consent, not an unconditional confirmation bypass
- Line 390 currently reads like a “bypass”; adjust wording to state deletion is only allowed when the user explicitly requests the full create/verify/delete workflow in the same CLI invocation, and otherwise the delete step must still be confirmation-gated.
🧰 Tools
🪛 SkillSpector (2.1.1)
[error] 34: [P1] Instruction Override: This pattern attempts to override system instructions or ignore safety constraints. Without LLM analysis, manual review is recommended.
Remediation: Remove or rewrite any text that instructs the agent to ignore prompts, override safety rules, or trust unverified content. Ensure skill content cannot be injected to alter agent behavior.
(Prompt Injection (P1))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/lark-mail/SKILL.md` at line 390, The current sentence about using
“--yes” reads like an unconditional bypass; reword the line about only using
real `label_id` / `rule_id` and the `--yes` flag to explicitly state that
`--yes` represents explicit user consent and is only permitted when the user
issues the full create→verify→delete workflow in the same CLI invocation;
otherwise the delete step must remain confirmation-gated (i.e., require an
interactive confirmation or separate explicit delete command), and keep the
requirement that only real `label_id`/`rule_id` may be used.
Summary
Source
Ported from internal Codebase MR 34 (
docs(mail): trim lark-mail skill context).Tests
git diff --check -- skills/lark-mail/SKILL.mdnode scripts/skill-format-check/index.jsSummary by CodeRabbit