feat: surface search API notices - #1413
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughEight search and list shortcuts now capture an optional API ChangesNotice Field Passthrough Feature
Sequence DiagramsequenceDiagram
participant User as CLI User
participant Shortcut as Search Shortcut<br/>(Doc/Drive/IM/Mail/Minutes/Task/VC)
participant API as Larksuite API
participant Output as JSON Output
User->>Shortcut: execute search (--format json)
Shortcut->>API: POST /search endpoint
API-->>Shortcut: {data: {results[], notice?}}
Shortcut->>Shortcut: capture notice if present
Shortcut->>Output: emit {data: {results[], notice?}}
Output-->>User: JSON with optional notice field
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sa: safe doc: none cfg: none test: unit test
beee97e to
6f3e956
Compare
BytedanceSearch
left a comment
There was a problem hiding this comment.
Approved per request.
BytedanceSearch
left a comment
There was a problem hiding this comment.
LGTM. Reviewed notice passthrough paths and targeted tests passed locally.
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@43fc2877409d37d21807ee255ba8c9fa60ee9f4f🧩 Skill updatenpx skills add arnold9672/cli#feat/search-notice-passthrough -y -g |
BytedanceSearch
left a comment
There was a problem hiding this comment.
LGTM. Re-reviewed after latest doc/comment update.
sa: safe
doc: none
cfg: none
test: unit test
Summary
Surface search API
noticestrings in CLI output so agents can see server-side search hints such as query truncation.Changes
data.noticefor search shortcuts that rebuild output across contact, docs, drive, IM, mail, minutes, task, and VC.Test Plan
go test -count=1 ./shortcuts/contact ./shortcuts/doc ./shortcuts/drive ./shortcuts/im ./shortcuts/mail ./shortcuts/minutes ./shortcuts/task ./shortcuts/vcmake unit-testattempted; failed in unrelated existing checks: schema envelope count expected >=193 but got 184, and apps tests require a git binary supportinggit init --initial-branch.lark-cli <domain> <command>flow works as expectedRelated Issues
Summary by CodeRabbit
New Features
data.noticeinto JSON output across Drive, Docs, IM (chat/messages), Tasks, Minutes, VC, and Contact.noticein per-query results and (when applicable) the top-level response.+triageoutputsnoticein structured JSON and prints it to stderr in default table mode.noticebehavior.Tests
data.noticepropagation and truncation/overlong-query handling.