Skip to content

chore: add CODEOWNERS for internal/ and new skills domains - #1420

Merged
liangshuo-1 merged 1 commit into
mainfrom
chore/codeowners-approval-rules
Jun 12, 2026
Merged

chore: add CODEOWNERS for internal/ and new skills domains#1420
liangshuo-1 merged 1 commit into
mainfrom
chore/codeowners-approval-rules

Conversation

@liangshuo-1

@liangshuo-1 liangshuo-1 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Require @liangshuo-1's approval for changes under internal/ and for new business domains under skills/.

Changes

  • Add .github/CODEOWNERS

Test Plan

  • No code changes; the main ruleset already enforces code owner review.

Related Issues

  • None

Summary by CodeRabbit

  • Chores
    • Updated repository code ownership configuration to assign review ownership for internal areas and the skills directory, including specific skill subdirectories.

Note: This is an internal development update with no impact on end-user functionality.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9b304d0-6c32-4573-aafa-fca494d84dd1

📥 Commits

Reviewing files that changed from the base of the PR and between 8e73333 and 3e2b3a8.

📒 Files selected for processing (1)
  • .github/CODEOWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/CODEOWNERS

📝 Walkthrough

Walkthrough

This PR introduces a .github/CODEOWNERS configuration file that establishes GitHub code owner review requirements. It assigns ownership of internal/ directory and specific skills/lark-* subdirectories to @liangshuo-1, with documentation of pattern matching behavior.

Changes

Code ownership configuration

Layer / File(s) Summary
CODEOWNERS configuration
.github/CODEOWNERS
Adds ownership patterns assigning internal/, /skills/, and enumerated skills/lark-* subpaths to @liangshuo-1, with a comment explaining “last match wins” and that only new skills/ entries need review.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

size/M

Suggested reviewers

  • MaxHuang22

Poem

🐰 I hopped through paths both wide and small,
A CODEOWNERS note upon the wall.
Internal nests now marked with care,
Skills lined up in tidy pair.
Hop, review, and merge—I'm glad to share!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding CODEOWNERS for internal/ and new skills domains.
Description check ✅ Passed The description covers all required template sections with clear summary, changes, test plan, and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/codeowners-approval-rules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S Low-risk docs, CI, test, or chore only changes label Jun 12, 2026
Change-Id: I8357d9bda24744ae1f7a716980a865d6926927ab
@liangshuo-1
liangshuo-1 force-pushed the chore/codeowners-approval-rules branch from 8e73333 to 3e2b3a8 Compare June 12, 2026 03:05
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@3e2b3a851c12b848bb4ed5ac6a378a2813c849c0

🧩 Skill update

npx skills add larksuite/cli#chore/codeowners-approval-rules -y -g

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (510545f) to head (3e2b3a8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         732      732           
  Lines       69140    69140           
=======================================
  Hits        50356    50356           
  Misses      15003    15003           
  Partials     3781     3781           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liangshuo-1
liangshuo-1 merged commit 76ba6fa into main Jun 12, 2026
19 of 21 checks passed
@liangshuo-1
liangshuo-1 deleted the chore/codeowners-approval-rules branch June 12, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Low-risk docs, CI, test, or chore only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants