feat: align im feed shortcut commands with latest oapi#1437
Closed
zhangheng023 wants to merge 1 commit into
Closed
feat: align im feed shortcut commands with latest oapi#1437zhangheng023 wants to merge 1 commit into
zhangheng023 wants to merge 1 commit into
Conversation
github-actions
Bot
added
domain/im
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR increases the IM feed shortcut batch limit from 10 to 30 chat IDs per call and simplifies the list command by removing pagination and detail-enrichment features. All command metadata, tests, and documentation are updated to reflect these changes. ChangesIM Feed Shortcut Updates
Sequence Diagram(s)sequenceDiagram
participant Client
participant ImFeedShortcutList
participant API as GET /open-apis/im/v2/feed_shortcuts
Client->>ImFeedShortcutList: +feed-shortcut-list
ImFeedShortcutList->>API: Single GET request
API-->>ImFeedShortcutList: {data.shortcuts: [{feed_card_id, type}]}
ImFeedShortcutList-->>Client: Full shortcut list (no pagination, no detail enrichment)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 72.83% 72.81% -0.02%
==========================================
Files 731 733 +2
Lines 69111 69190 +79
==========================================
+ Hits 50335 50380 +45
- Misses 14999 15028 +29
- Partials 3777 3782 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@a7ccd4e63694e92c0079bf2715f274f3044df6db🧩 Skill updatenpx skills add larksuite/cli#feat/feed-shortcut-oapi-align -y -g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the existing
imfeed shortcut commands with the latestim/v2/feed_shortcutsOAPI contract. This removes outdated list pagination/detail behavior, tightens local write validation to a 30-item CLI limit, and keeps the shortcut docs plus existing E2E coverage consistent with the shipped behavior.Changes
im +feed-shortcut-createandim +feed-shortcut-removewith the latest contract while enforcing a local 30-item batch limit.im +feed-shortcut-listinto a direct full-list wrapper and remove legacy--page-token,--no-detail, and detail enrichment behavior.lark-imfeed shortcut reference docs to match the new behavior.Test Plan
lark-cli <domain> <command>flow works as expectedgo test ./shortcuts/imgo test ./tests/cli_e2e/im -run 'TestIM_FeedShortcut' -count=1 -vbash /Users/bytedance/.codex/plugins/cache/lark-cli-harness-codex-marketplace/lark-cli-harness/0.6.6/skills/dev-verify/scripts/validate.shdocs/superpowers/verify_results/acceptance_review.md)docs/superpowers/verify_results/security-code-review.md)Related Issues
Summary by CodeRabbit
Changes
Documentation