docs: slim lark-event references to recipes and gotchas - #1451
docs: slim lark-event references to recipes and gotchas#1451liuxinyanglxy wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughDocumentation refactor trims per-key catalogs across IM, VC, Minutes, and Whiteboard guides, consolidating schema discovery to lark-cli and emphasizing payload “gotchas” and practical ChangesEvent Documentation Restructuring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 72.82% 73.32% +0.49%
==========================================
Files 731 750 +19
Lines 69096 69240 +144
==========================================
+ Hits 50320 50769 +449
+ Misses 14999 14733 -266
+ Partials 3777 3738 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1a09c5fc7f7db2401e7ebeee4eb6ef0e5db1b420🧩 Skill updatenpx skills add liuxinyanglxy/cli#docs/lark-event-skill-slim -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-event/SKILL.md`:
- Line 151: Update the VC coverage row wording to explicitly state that the VC
field note_source is conditional by source_type; replace the current
“note_source meeting-only” phrasing with a clearer phrase such as “note_source
only present when source_type == 'meeting'” (mirroring the language used in
references/lark-event-vc.md) so it cannot be confused with the Minutes row’s
wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 124501cd-bd8a-4271-bfb8-a72198f2bd16
📒 Files selected for processing (5)
skills/lark-event/SKILL.mdskills/lark-event/references/lark-event-im.mdskills/lark-event/references/lark-event-minutes.mdskills/lark-event/references/lark-event-vc.mdskills/lark-event/references/lark-event-whiteboard.md
References (im/vc/minutes/whiteboard) dropped key catalogs, field/scope tables, and other content already emitted by `event list` / `event schema`, keeping only jq recipes, domain semantic gotchas, required params, and per-key identity. ~55% token reduction across the four files. vc documents the 3 previously-undocumented recording keys, then replaces the hardcoded catalog with a pointer to `event list` to stop doc-vs-code drift. whiteboard keeps the user_id conditional-presence note, which the schema cannot express. SKILL.md Topic index reworded to advertise recipes/gotchas and route structure lookups to the CLI. Validated by a command-correctness eval (skill + CLI available): 21/21 across the four domains, identity correct per key, whiteboard required `-p whiteboard_id` preserved, VC recording-transcript key now resolves. Change-Id: I4d7fd8bae50a0f84396080d350bda8c358aa5e82
e87deef to
1a09c5f
Compare
Summary
Refocuses the lark-event skill on what the CLI cannot express. Structure (key catalog, fields, types, enums, scopes, per-key identity) is discoverable via
event list/event schema, so the references no longer duplicate it — they keep only jq recipes, domain semantic gotchas, required params, and identity reminders.Changes
skills/lark-event/references/lark-event-im.md: drop the 11-key catalog and field/shape tables; keep jq recipes +.contentdecoding gotchas (~43% smaller)skills/lark-event/references/lark-event-vc.md: document the 3 recording keys, then replace the hardcoded catalog with a pointer toevent list; keep behavior gotchas + recipes (~70% smaller)skills/lark-event/references/lark-event-minutes.md: drop catalog/scope/field tables; keep the enrichment gotcha + recipes (~43% smaller)skills/lark-event/references/lark-event-whiteboard.md: drop catalog/scope/field/lifecycle tables; keep the required-p whiteboard_idgotcha, theuser_idconditional-presence note (not in schema), and recipes (~52% smaller)skills/lark-event/SKILL.md: reword Topic index rows to advertise recipes/gotchas and route structure lookups to the CLITest Plan
make unit-test— docs-only change, no Go code modified-p whiteboard_idpreserved, VC recording-transcript key resolvesRelated Issues
N/A
Summary by CodeRabbit