fix(event): clarify remote bus blocker recovery#1454
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe error message and hint returned by ChangesRemote Bus Precondition Error Message and Test
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves the error messaging when a remote event bus connection is already active, making it clearer that local CLI commands won’t affect remote connections and suggesting appropriate remediation steps.
Changes:
- Updated the validation error message/hint emitted when the API reports an existing remote bus connection.
- Updated the corresponding test to assert the new hint content via multiple required substrings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/event/consume/startup.go | Refines the failed-precondition error copy and expands the hint for remote-connection scenarios. |
| internal/event/consume/startup_guard_test.go | Adjusts assertions to match and enforce the new multi-part hint messaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 750 750
Lines 69250 69250
=======================================
Hits 50799 50799
Misses 14711 14711
Partials 3740 3740 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@42e948fed9b90629568470ce5bec386ef83d46c6🧩 Skill updatenpx skills add Zhang-986/cli#codex/event-remote-blocker-guidance -y -g |
Summary
Fixes #1381.
Tests
go test ./internal/event/consume -run TestEnsureBus_RemoteBusAlreadyConnectedIsFailedPrecondition -count=1(fails before the fix, passes after)go test ./internal/event/consume ./cmd/event -count=1go test ./internal/event/consume ./cmd/event ./errs -count=1git diff --checkSummary by CodeRabbit