clarify lark-doc create title guidance - #1474
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThree skill reference documentation files for the ChangesTitle Formatting Rules for
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
=======================================
Coverage 73.39% 73.39%
=======================================
Files 750 750
Lines 69288 69290 +2
=======================================
+ Hits 50851 50853 +2
Misses 14695 14695
Partials 3742 3742 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
shortcuts/doc/docs_create_test.go (1)
20-45: ⚡ Quick winExercise the mounted
DocsCreatehelp output here.
v2CreateFlags()only checks the helper strings; it won’t catch a regression in the publicdocs +create --helpwiring ifDocsCreate.Flagsstops including these flags. If the goal is to lock the user-visible contract, mount the command and assert the rendered help instead. Based on theDocsCreatewiring inshortcuts/doc/docs_create.go.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/doc/docs_create_test.go` around lines 20 - 45, The test TestDocsCreateV2HelpMentionsTitleRules currently only validates flag descriptions from the v2CreateFlags() helper function directly, which won't catch regressions if the DocsCreate.Flags wiring in shortcuts/doc/docs_create.go stops including these flags in the actual command. To properly lock the user-visible contract, mount the DocsCreate command and assert the rendered help output (what users see when running docs +create --help) instead of checking the flag helper strings directly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@shortcuts/doc/docs_create_test.go`:
- Around line 20-45: The test TestDocsCreateV2HelpMentionsTitleRules currently
only validates flag descriptions from the v2CreateFlags() helper function
directly, which won't catch regressions if the DocsCreate.Flags wiring in
shortcuts/doc/docs_create.go stops including these flags in the actual command.
To properly lock the user-visible contract, mount the DocsCreate command and
assert the rendered help output (what users see when running docs +create
--help) instead of checking the flag helper strings directly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d3cf8428-4da6-4e4e-a704-6b39e2a0ef71
📒 Files selected for processing (4)
shortcuts/doc/docs_create_test.goshortcuts/doc/docs_create_v2.goskills/lark-doc/references/lark-doc-create.mdskills/lark-doc/references/lark-doc-md.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1f12fc0777b004147bb007c8641b8eb773d4b724🧩 Skill updatenpx skills add larksuite/cli#clarify-doc-create-title-guidance -y -g |
bc37219 to
261fa38
Compare
261fa38 to
1f12fc0
Compare
Summary
<title>, Markdown uses a leading unique# Title, and Markdown body sections should start at##.Untitled.Tests
Summary by CodeRabbit
<title>element per document