Skip to content

feat(vc): support agent meeting event workflows#1483

Merged
zhicong666-bytedance merged 12 commits into
mainfrom
feat/vc-agent-active-meetings
Jun 16, 2026
Merged

feat(vc): support agent meeting event workflows#1483
zhicong666-bytedance merged 12 commits into
mainfrom
feat/vc-agent-active-meetings

Conversation

@zhicong666-bytedance

@zhicong666-bytedance zhicong666-bytedance commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Improves VC agent meeting workflows, including active meeting discovery, meeting event reading, meeting ID selection, and join/leave guidance.

Changes

  • Add vc +meeting-list-active to discover active meetings for the current user or a target user.
  • Allow VC agent meeting shortcuts to support app-identity meeting flows.
  • Refine lark-vc-agent skill guidance for active meeting discovery, event reading, join/leave flow, pagination, and meeting ID selection.
  • Clarify that agents should preserve the identity context used to obtain a meeting_id when calling follow-up meeting APIs.
  • Add guidance for direct “what happened in this meeting” questions, including meeting number matching and multiple active meeting selection.
  • Clarify how to route post-meeting product lookup through lark-vc by first fetching meeting product metadata.
  • Add VC shortcut tests for active meeting validation, request construction, dry-run behavior, and shortcut registration.

Test Plan

  • git diff --check
  • go test ./shortcuts/vc
  • go build ./...

Related Issues

  • None

Summary by CodeRabbit

  • New Features

    • Added new +meeting-list-active command to discover and list currently active meetings.
    • Extended bot authentication support for meeting join, leave, and event-reading operations.
  • Bug Fixes

    • Improved validation for meeting IDs to detect invalid 9-digit meeting numbers with clearer error guidance.
  • Documentation

    • Updated skill guides with detailed routing logic, identity usage rules, troubleshooting steps, and command examples for all meeting operations.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5770f247-a998-4ec1-bac4-4699a990705b

📥 Commits

Reviewing files that changed from the base of the PR and between 8560bb9 and 4dd775b.

📒 Files selected for processing (1)
  • skills/lark-vc-agent/SKILL.md
✅ Files skipped from review due to trivial changes (1)
  • skills/lark-vc-agent/SKILL.md

📝 Walkthrough

Walkthrough

Adds a new +meeting-list-active VC shortcut (VCMeetingListActive) that calls GET /open-apis/vc/v1/bots/user_active_meeting with identity-aware --user-id validation. Expands AuthTypes to include "bot" on VCMeetingJoin, VCMeetingLeave, and VCMeetingEvents. Adds 9-digit meeting-number rejection in VCMeetingEvents validation. Updates skill documentation to enforce identity continuity rules across join/list-active/events/leave flows.

Changes

VC Meeting List Active and Bot Auth Expansion

Layer / File(s) Summary
Bot AuthTypes expansion and meeting-number validation
shortcuts/vc/vc_meeting_join.go, shortcuts/vc/vc_meeting_leave.go, shortcuts/vc/vc_meeting_events.go, shortcuts/vc/vc_meeting_events_test.go
VCMeetingJoin, VCMeetingLeave, and VCMeetingEvents each add "bot" to their AuthTypes. validateMeetingEventsMeetingID gains a validMeetingNumber check that returns a typed ValidationError when a 9-digit number is supplied. Tests verify the rejection and that +meeting-list-active appears in the registered shortcut list.
VCMeetingListActive shortcut implementation
shortcuts/vc/vc_meeting_list_active.go, shortcuts/vc/shortcuts.go
New VCMeetingListActive shortcut targets GET /open-apis/vc/v1/bots/user_active_meeting. Includes bot-only --user-id validation (validateMeetingListActiveUserID), a conditional param builder (buildMeetingListActiveParams), dry-run support, execute flow, and pretty-print output with empty/single/multiple-meeting handling. Shortcut registered in Shortcuts().
VCMeetingListActive tests
shortcuts/vc/vc_meeting_test.go
330 lines of new tests covering user/bot dry-run, user-mode --user-id ignore, bot validation errors (missing/invalid OpenID), execute with user_id query param, empty/single/multiple pretty-format output, code=121005 mapped to *errs.PermissionError, and a shared validation-error assertion helper.
SKILL.md routing and identity rules
skills/lark-vc-agent/SKILL.md
Adds +meeting-list-active to the shortcut table and routing matrix. Rewrites 身份路由 with --as user vs --as bot rules and a hard continuity constraint tying meeting_id provenance to the identity used for +meeting-events. Tightens core instructions for join/events/leave. Replaces inline permission table with ordered troubleshooting sections.
Skill reference docs
skills/lark-vc-agent/references/lark-vc-agent-meeting-list-active.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-events.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-join.md, skills/lark-vc-agent/references/lark-vc-agent-meeting-leave.md
New lark-vc-agent-meeting-list-active.md documents user/bot identity semantics, multi-result handling, 9-digit matching, and common errors. Updated meeting-events/join/leave reference docs enforce --as bot, long meeting_id usage, identity-scoped page_token pagination, and cross-link to +meeting-list-active.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • larksuite/cli#824: Directly modifies VCMeetingEvents in shortcuts/vc/vc_meeting_events.go, the same file this PR expands with bot AuthTypes and 9-digit meeting-number validation.

Suggested labels

documentation

Suggested reviewers

  • zhaoleibd

🐇 A new command hops into the warren today,
+meeting-list-active is here to stay!
Bot or user, identity held tight,
Nine-digit numbers? Rejected on sight! 🚫
Long meeting_ids lead the way — 🎉
The bunny checks identities, hip-hip-hooray!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(vc): support agent meeting event workflows' directly describes the main change: adding support for agent meeting event workflows in the VC module, which is the primary objective of this PR.
Description check ✅ Passed The PR description includes all required template sections: Summary, Changes (with detailed bullet points), Test Plan (with checkmarks for verification steps), and Related Issues. The content is substantive and directly addresses the PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/vc-agent-active-meetings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/vc PR touches the vc domain size/L Large or sensitive change across domains or core paths labels Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.40%. Comparing base (a0e83c7) to head (4dd775b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   73.37%   73.40%   +0.02%     
==========================================
  Files         751      752       +1     
  Lines       69856    69939      +83     
==========================================
+ Hits        51256    51337      +81     
- Misses      14802    14803       +1     
- Partials     3798     3799       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@4dd775bdc7f23de974ec430e8ddd75b33a8294c1

🧩 Skill update

npx skills add larksuite/cli#feat/vc-agent-active-meetings -y -g

@zhicong666-bytedance
zhicong666-bytedance merged commit bb03c8a into main Jun 16, 2026
21 checks passed
@zhicong666-bytedance
zhicong666-bytedance deleted the feat/vc-agent-active-meetings branch June 16, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/vc PR touches the vc domain size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants