Skip to content

docs: remove write-then-readback constraint from lark-calendar skill#1509

Closed
calendar-assistant wants to merge 1 commit into
mainfrom
feat/calendar-skip-write-readback
Closed

docs: remove write-then-readback constraint from lark-calendar skill#1509
calendar-assistant wants to merge 1 commit into
mainfrom
feat/calendar-skip-write-readback

Conversation

@calendar-assistant

@calendar-assistant calendar-assistant commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove the "wait 2 seconds then read-back" constraint from lark-calendar write operations. The Agent now trusts the API response directly, significantly reducing end-to-end latency for calendar create/update/delete flows.

Changes

  • skills/lark-calendar/SKILL.md: Removed the "verify after delete/update" row from the precondition routing table; added an explicit blockquote stating that write operations must not trigger a secondary read-back.
  • skills/lark-calendar/references/lark-calendar-update.md: Removed the "wait at least 2 seconds before querying" note.

Test Plan

  • Skill docs are pure prompt constraints with no code changes — no unit tests required
  • Locally verified lark-cli calendar --help outputs correctly

Related Issues

  • None

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated calendar operation guidelines: write operations now directly trust API results without requiring post-operation verification delays.
    • Enhanced documentation on combined action execution order and clarified error handling behavior when operations fail.

写操作后不再要求等待2秒回查验证,直接信任API返回结果,
减少不必要的耗时。

Change-Id: I2d7e1ecab4450839f8232e65d43bca39e851ae22
@CLAassistant

CLAassistant commented Jun 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 967fb25c-55c5-4392-a06b-594a494e180f

📥 Commits

Reviewing files that changed from the base of the PR and between c5b5aec and a57cd05.

📒 Files selected for processing (2)
  • skills/lark-calendar/SKILL.md
  • skills/lark-calendar/references/lark-calendar-update.md
💤 Files with no reviewable changes (1)
  • skills/lark-calendar/references/lark-calendar-update.md

📝 Walkthrough

Walkthrough

Two lark-calendar documentation files are updated to remove the requirement to wait 2 seconds and re-query after write operations. SKILL.md replaces the post-delete/modify verification rule with a direct-trust-API-result rule. lark-calendar-update.md adds +update combination action execution order and non-rollback behavior, and removes the 2-second wait prompt.

Changes

Lark Calendar write-operation verification policy

Layer / File(s) Summary
Remove re-query rule and add +update execution order docs
skills/lark-calendar/SKILL.md, skills/lark-calendar/references/lark-calendar-update.md
SKILL.md prerequisite routing replaces the post-write "wait 2s then re-query" rule with a direct-trust-API-result rule. lark-calendar-update.md adds +update combination action execution order (event fields → remove attendees → add attendees), a no-automatic-rollback-on-failure note, and removes the 2-second wait verification prompt.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • larksuite/cli#678: Previously introduced calendar +update shortcut semantics that this PR now aligns documentation with, specifically regarding execution order and removal of the 2-second re-query verification.
  • larksuite/cli#1269: Also modified skills/lark-calendar/SKILL.md routing and prerequisite constraints, directly overlapping with the same documentation logic section modified in this PR.

Suggested labels

domain/calendar, size/S

Suggested reviewers

  • hugang-lark

Poem

🐇 No more waiting, two seconds gone,
The API returns — just trust and move on!
First fields, then remove, then add with flair,
If steps half-done, the error's right there.
Hop, hop, hooray — less wait, more cheer! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the write-then-readback constraint from the lark-calendar skill.
Description check ✅ Passed The PR description covers all required template sections: Summary, Changes, Test Plan, and Related Issues with clear explanations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/calendar-skip-write-readback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.72%. Comparing base (4a4c334) to head (a57cd05).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   73.52%   73.72%   +0.19%     
==========================================
  Files         783      780       -3     
  Lines       74630    74140     -490     
==========================================
- Hits        54874    54659     -215     
+ Misses      15662    15420     -242     
+ Partials     4094     4061      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@a57cd05f5c99f9a8b078039a23be3f987b2dad66

🧩 Skill update

npx skills add larksuite/cli#feat/calendar-skip-write-readback -y -g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants