fix: add missing CLI headers for git credential helper - #1539
Conversation
📝 WalkthroughWalkthroughAdds a "reported shortcut" tag to the Git credential factory issuer path. A new constant names the shortcut, a new helper attaches it (with a UUID instance value) to the context only when no shortcut exists, and the factory issuer's ChangesGit credential helper shortcut tagging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@15375b6c96974f5d476e2d6fb822eb4f97ddadd9🧩 Skill updatenpx skills add raistlin042/cli#fix/cli-shortcut-telemetry-null -y -g |
fd27484 to
15375b6
Compare
Summary
Fix missing standard CLI headers on requests issued by the apps Git credential helper path.
Changes
Test Plan
go test -race ./shortcuts/apps -run 'TestFactoryIssuerBranches|TestContextWithGitCredentialHelperShortcutPreservesExistingShortcut' -count=1go test -race ./shortcuts/apps -count=1go test -v -count=1 -timeout=5m ./tests/cli_e2e/apps -run 'TestAppsGitCredential'Related Issues