Skip to content

feat(base): tighten base skill failure handling#1660

Open
yballul-bytedance wants to merge 1 commit into
larksuite:mainfrom
yballul-bytedance:auto-research-sync/01KW9WN5SNESQ8JV5S8QQHZ36Z/mr-771-4c478e05
Open

feat(base): tighten base skill failure handling#1660
yballul-bytedance wants to merge 1 commit into
larksuite:mainfrom
yballul-bytedance:auto-research-sync/01KW9WN5SNESQ8JV5S8QQHZ36Z/mr-771-4c478e05

Conversation

@yballul-bytedance

@yballul-bytedance yballul-bytedance commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Tighten the lark-base skill guidance for attachment path handling and authentication failures.

Changes

  • Limit local attachment lookup to the exact current-working-directory path and one files/ fallback.
  • Stop further Base probing when a Base command returns authentication/token_missing, and direct users to authenticate or grant the missing scope.

Test Plan

  • git diff --check

Related Issues

Auto research task: 01KW9WN5SNESQ8JV5S8QQHZ36Z

Summary by CodeRabbit

  • Bug Fixes
    • Improved local attachment handling by limiting checks to supported locations and clearly reporting when required files are missing.
    • Streamlined authentication failure handling by stopping further Base detection and directing users to run lark-cli auth login --domain base (or request the missing authorization scope) instead of showing extra auth guidance.

@github-actions github-actions Bot added domain/base PR touches the base domain size/M Single-domain feat or fix with limited business impact labels Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8641da1-9f3d-4ca7-8ebb-949e11898a68

📥 Commits

Reviewing files that changed from the base of the PR and between 1feea61 and ce45054.

📒 Files selected for processing (1)
  • skills/lark-base/SKILL.md
✅ Files skipped from review due to trivial changes (1)
  • skills/lark-base/SKILL.md

📝 Walkthrough

Walkthrough

Two operational constraint rules were added to skills/lark-base/SKILL.md: one limits local attachment path lookup and defines missing-file behavior; the other stops Base detection on authentication/token_missing and specifies the auth guidance to provide.

Changes

Lark Base Skill Boundary Rules

Layer / File(s) Summary
Usage boundary constraints
skills/lark-base/SKILL.md
Adds two rules: local attachment paths are restricted to cwd and files/<name>, stopping with a missing-file report if not found; authentication/token_missing responses halt further Base detection and trigger lark-cli auth login --domain base guidance without extra auth help or QR handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • larksuite/cli#374: Also changes skills/lark-base/SKILL.md guidance around Base routing and token handling.
  • larksuite/cli#708: Also updates skills/lark-base/SKILL.md to refine Base workflow routing and stop conditions.

Suggested reviewers

  • kongenpei

Poem

A rabbit found the rules just right,
No file hunts wandering through the night.
Token missing? Pause, take heed—
Login first, then onward speed. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR’s main change: tightening failure handling for the base skill.
Description check ✅ Passed The description covers the required Summary, Changes, Test Plan, and Related Issues sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@ce45054e09ded678b6a63270ae26b21631eb871d

🧩 Skill update

npx skills add yballul-bytedance/cli#auto-research-sync/01KW9WN5SNESQ8JV5S8QQHZ36Z/mr-771-4c478e05 -y -g

@yballul-bytedance
yballul-bytedance force-pushed the auto-research-sync/01KW9WN5SNESQ8JV5S8QQHZ36Z/mr-771-4c478e05 branch from 1feea61 to ce45054 Compare June 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/base PR touches the base domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant