chore: lark-cli docs support reference_map#1690
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SunPeiYang996
force-pushed
the
codex/html5-block-reference-map-core
branch
from
June 30, 2026 12:29
bc40989 to
9d0402b
Compare
SunPeiYang996
marked this pull request as ready for review
June 30, 2026 12:29
This comment has been minimized.
This comment has been minimized.
SunPeiYang996
force-pushed
the
codex/html5-block-reference-map-core
branch
from
June 30, 2026 12:41
9d0402b to
73fd00e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/doc/docs_fetch_v2_test.go`:
- Around line 582-608: The test
TestDocsFetchIMMarkdownIgnoresHTML5BlockInsideCodeFence only verifies success
and valid JSON, but it never asserts that the fenced html5-block was left
untouched. Update the test to inspect the decoded envelope from mountAndRunDocs
and confirm the response content still contains the original fenced
<html5-block> markup (or equivalent unchanged content), and that no error field
or reference-resolution side effect appears. Use the existing registerDocsAIStub
fixture and the parsed envelope variable to make the assertion explicit.
In `@shortcuts/doc/docs_update_test.go`:
- Around line 67-88: The dry-run test is asserting only a message substring from
the serialized error string, which cannot verify typed error metadata. Update
TestDocsUpdateDryRunReportsReferenceMapBuildError to call
buildUpdateBodyWithHTML5ReferenceMap(runtime) directly instead of relying on
dryRunUpdateV2, then assert the returned error with errs.ProblemOf for
category/subtype/param and confirm the underlying cause is preserved. Keep the
existing html5-block/missing reference setup, but remove the strings.Contains
check and any JSON envelope assertions that hide typed metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2ce7fc74-54c1-40a8-9e09-0658a3f49dd9
📒 Files selected for processing (9)
shortcuts/doc/docs_create_v2.goshortcuts/doc/docs_fetch_v2.goshortcuts/doc/docs_fetch_v2_test.goshortcuts/doc/docs_update_test.goshortcuts/doc/docs_update_v2.goshortcuts/doc/html5_block_resources.goshortcuts/doc/html5_block_resources_test.goskills/lark-doc/references/lark-doc-create.mdskills/lark-doc/references/lark-doc-update.md
✅ Files skipped from review due to trivial changes (2)
- skills/lark-doc/references/lark-doc-update.md
- skills/lark-doc/references/lark-doc-create.md
🚧 Files skipped from review as they are similar to previous changes (5)
- shortcuts/doc/docs_fetch_v2.go
- shortcuts/doc/docs_create_v2.go
- shortcuts/doc/docs_update_v2.go
- shortcuts/doc/html5_block_resources_test.go
- shortcuts/doc/html5_block_resources.go
fangshuyu-768
approved these changes
Jul 2, 2026
SunPeiYang996
force-pushed
the
codex/html5-block-reference-map-core
branch
from
July 2, 2026 04:24
da14cf2 to
fdc3273
Compare
Merged
This was referenced Jul 3, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This PR intentionally contains only the first reference_map plumbing commit from the working branch.
Validation
Summary by CodeRabbit
--reference-mapsupport for docs v2 create/update (inline JSON,@relative-file.json, or-for stdin) and introduced end-to-endhtml5-blockhandling, including fetch-time processing and optional large-HTML materialization.html5-blockis ignored inside markdown fenced code blocks during fetch.--reference-maprequirements.html5-block, flag behavior, and fetch/update/create rewriting.