docs: add lark slides generation constraints#1720
Conversation
github-actions
Bot
added
the
size/M
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR tightens lark-slides guidance in ChangesLark slides guidance update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
==========================================
+ Coverage 74.51% 74.72% +0.21%
==========================================
Files 852 853 +1
Lines 87655 88804 +1149
==========================================
+ Hits 65312 66359 +1047
- Misses 17315 17395 +80
- Partials 5028 5050 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@88df158229476641e05ab238292588cc68348c72🧩 Skill updatenpx skills add larksuite/cli#docs/slides_style -y -g |
|
Thanks for tightening the slide-generation guidance. I think two parts here should be narrowed before merge:
|
github-actions
Bot
added
size/XL
|
I found one blocking regression after the template toolchain removal.
TEMPLATES_DIR = Path(__file__).resolve().parents[1] / "assets" / "templates"
...
template_paths = sorted(TEMPLATES_DIR.glob("*.xml"))
self.assertTrue(template_paths)This PR deletes the entire python3 -m unittest xml_text_overlap_lint_test.pyResult: Could you either keep a small fixture XML set for this lint coverage, or update the test to use inline XML samples instead of the removed template directory? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-slides/SKILL.md (1)
32-34: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winKeep the template carve-out narrow. Only small existing-page edits should skip planning; imported-template rewrites that add/remove pages or replace structure still need
.lark-slides/plan/.../slide_plan.jsonbefore XML.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-slides/SKILL.md` around lines 32 - 34, The planning exemption is too broad and should be narrowed so only truly small edits to an existing page skip planning. Update the guidance in SKILL.md to make clear that imported-template rewrites which add/remove pages, replace structure, or otherwise materially modify the deck still must create .lark-slides/plan/<deck-or-task-id>/slide_plan.json before generating XML, and keep the carve-out limited to minor single-page content edits.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/lark-slides/SKILL.md`:
- Around line 32-34: The planning exemption is too broad and should be narrowed
so only truly small edits to an existing page skip planning. Update the guidance
in SKILL.md to make clear that imported-template rewrites which add/remove
pages, replace structure, or otherwise materially modify the deck still must
create .lark-slides/plan/<deck-or-task-id>/slide_plan.json before generating
XML, and keep the carve-out limited to minor single-page content edits.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9bdbe7b5-2f21-48ea-9369-2c7b06f199cc
📒 Files selected for processing (49)
skills/lark-slides/SKILL.mdskills/lark-slides/assets/templates/administration--all_hands_meeting.xmlskills/lark-slides/assets/templates/administration--annual_gala.xmlskills/lark-slides/assets/templates/administration--company_intro.xmlskills/lark-slides/assets/templates/administration--corporate_culture.xmlskills/lark-slides/assets/templates/hr--employee_training.xmlskills/lark-slides/assets/templates/hr--employee_training_workshop.xmlskills/lark-slides/assets/templates/hr--onboarding.xmlskills/lark-slides/assets/templates/marketing--brand_communication.xmlskills/lark-slides/assets/templates/marketing--brand_logo_design.xmlskills/lark-slides/assets/templates/marketing--brand_operations_plan.xmlskills/lark-slides/assets/templates/marketing--business_plan.xmlskills/lark-slides/assets/templates/marketing--marketing_plan.xmlskills/lark-slides/assets/templates/marketing--marketing_strategy.xmlskills/lark-slides/assets/templates/marketing--product_whitepaper.xmlskills/lark-slides/assets/templates/marketing--roadshow_business_plan.xmlskills/lark-slides/assets/templates/misc--book_sharing.xmlskills/lark-slides/assets/templates/misc--club_event_plan.xmlskills/lark-slides/assets/templates/misc--student_career_plan.xmlskills/lark-slides/assets/templates/office--dark_general.xmlskills/lark-slides/assets/templates/office--dept_annual_report.xmlskills/lark-slides/assets/templates/office--light_general.xmlskills/lark-slides/assets/templates/office--project_kickoff.xmlskills/lark-slides/assets/templates/office--quarterly_review.xmlskills/lark-slides/assets/templates/office--work_report.xmlskills/lark-slides/assets/templates/office--work_summary.xmlskills/lark-slides/assets/templates/office--work_summary_report.xmlskills/lark-slides/assets/templates/operations--brand_logo_design.xmlskills/lark-slides/assets/templates/operations--brand_operations_plan.xmlskills/lark-slides/assets/templates/operations--marketing_plan.xmlskills/lark-slides/assets/templates/operations--product_promotion.xmlskills/lark-slides/assets/templates/personal--experience_sharing.xmlskills/lark-slides/assets/templates/personal--personal_resume.xmlskills/lark-slides/assets/templates/personal--promotion_defense.xmlskills/lark-slides/assets/templates/personal--promotion_report.xmlskills/lark-slides/assets/templates/personal--self_intro.xmlskills/lark-slides/assets/templates/personal--teaching_sharing.xmlskills/lark-slides/assets/templates/product--business_case_analysis.xmlskills/lark-slides/assets/templates/product--market_analysis.xmlskills/lark-slides/assets/templates/product--product_analysis.xmlskills/lark-slides/assets/templates/product--product_intro.xmlskills/lark-slides/assets/templates/product--product_promotion.xmlskills/lark-slides/assets/templates/product--product_promotion_2.xmlskills/lark-slides/references/planning-layer.mdskills/lark-slides/references/template-catalog.mdskills/lark-slides/references/template-index.jsonskills/lark-slides/references/visual-planning.mdskills/lark-slides/scripts/template_tool.pyskills/lark-slides/scripts/template_tool_test.py
💤 Files with no reviewable changes (14)
- skills/lark-slides/assets/templates/marketing--business_plan.xml
- skills/lark-slides/assets/templates/marketing--product_whitepaper.xml
- skills/lark-slides/assets/templates/hr--onboarding.xml
- skills/lark-slides/assets/templates/administration--corporate_culture.xml
- skills/lark-slides/assets/templates/marketing--marketing_strategy.xml
- skills/lark-slides/assets/templates/marketing--brand_communication.xml
- skills/lark-slides/assets/templates/administration--company_intro.xml
- skills/lark-slides/assets/templates/administration--annual_gala.xml
- skills/lark-slides/assets/templates/marketing--brand_operations_plan.xml
- skills/lark-slides/assets/templates/hr--employee_training.xml
- skills/lark-slides/assets/templates/marketing--marketing_plan.xml
- skills/lark-slides/assets/templates/hr--employee_training_workshop.xml
- skills/lark-slides/assets/templates/marketing--roadshow_business_plan.xml
- skills/lark-slides/assets/templates/marketing--brand_logo_design.xml
2 participants
Summary
Add a high-priority lark-slides skill constraint for PPT generation and template editing behavior, and remove the older built-in template-tool path to avoid conflicting template routing.
Changes
Test Plan
git diff --checktemplate_tool/template-catalog/template-index/assets/templatesreferences remain underskills/lark-slidesRelated Issues
Summary by CodeRabbit