Skip to content

Document mail allow/block sender commands#1741

Open
qiooo wants to merge 2 commits into
larksuite:mainfrom
qiooo:feat/99dc114
Open

Document mail allow/block sender commands#1741
qiooo wants to merge 2 commits into
larksuite:mainfrom
qiooo:feat/99dc114

Conversation

@qiooo

@qiooo qiooo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Updates the mail command references so user mailbox allow/block sender operations are documented and discoverable.

  • Adds allow/block sender concepts and command coverage to the mail domain guidance.
  • Refreshes the lark-mail skill docs with list, batch_set, and batch_delete command entries.
  • Includes parameter and dry-run examples for the generated commands.

Summary by CodeRabbit

  • Documentation
    • Expanded mail usage guidance with clearer sending confirmations, timed-send checks, HTML writing/linting rules, template handling, and send_as examples.
    • Added user-level sender allow/block list guidance, including list/search, batch add/remove examples, and required confirmation/error-handling steps.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/L Large or sensitive change across domains or core paths labels Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 031134b8-13c0-41eb-8f25-104f07d621ee

📥 Commits

Reviewing files that changed from the base of the PR and between c23d583 and ef453fa.

📒 Files selected for processing (1)
  • skills/lark-mail/SKILL.md

📝 Walkthrough

Walkthrough

This PR revises Feishu mail skill documentation across two files, adding user-level allow/block sender list management via native API, stricter send confirmation and send_status verification flows, expanded HTML linting/template rules, and a comprehensive API resources and permission reference table.

Changes

Mail skill documentation update

Layer / File(s) Summary
Description, auth directive, and core concepts update
skills/lark-mail/SKILL.md
Broadens skill description, shortens auth-read directive, and adds "Allow / Block Senders" to core concepts.
Typical workflow and recipient search guidance
skills/lark-mail/SKILL.md
Reworks workflow steps, adds mandatory -h check before first shortcut/API use, and rewrites recipient search with confirmation and "not found" handling.
Send confirmation, delivery status, and send-as flow
skills/lark-mail/SKILL.md
Adds pre-send confirmation, post-send send_status checks, timed-send/cancel-timer rules, and a new send_as flow for public mailboxes/aliases.
HTML linting and email template rules
skills/lark-mail/SKILL.md
Adds raw-EML prohibition, documents built-in HTML lint behavior on write path, and expands email template create/update and merge/override rules.
Allow/Block sender list management
skills/lark-mail/SKILL.md, skill-template/domains/mail.md
Adds native API examples for listing/searching and batch add/remove of allow/block senders, with confirmation, failed_items, and cache-retry rules.
API resources and permission table reference
skills/lark-mail/SKILL.md
Adds +lint-html shortcut entry, an API Resources method inventory, and a permission-to-scope mapping table.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Skill
  participant MailAPI
  User->>Skill: request send email
  Skill->>User: confirm recipients and content
  User->>Skill: confirm
  Skill->>MailAPI: send message (send_as/timed options)
  MailAPI-->>Skill: send result
  Skill->>MailAPI: query send_status
  MailAPI-->>Skill: delivery status
  Skill->>User: report delivery status
Loading

Possibly related PRs

  • larksuite/cli#749: Adds similar pre-write confirmation and batch operation failure-handling rules to the same mail skill documentation set.

Suggested reviewers: chanthuang, infeng, haidaodashushu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: documenting mail allow/block sender commands.
Description check ✅ Passed The description covers the summary and main changes, but it omits the template's Test Plan and Related Issues sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-mail/SKILL.md`:
- Around line 741-746: The sender-list scope table is over-permissive because
the `user_mailbox.allow_senders.list` and `user_mailbox.blocked_senders.list`
entries are read-only but are currently mapped to
`mail:user_mailbox.message:modify`. Update the permission mapping in `SKILL.md`
so the `list` rows use the appropriate readonly scope, while keeping
`mail:user_mailbox.message:modify` only for
`user_mailbox.allow_senders.batch_create`,
`user_mailbox.allow_senders.batch_remove`,
`user_mailbox.blocked_senders.batch_create`, and
`user_mailbox.blocked_senders.batch_remove`.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 388ab9b8-c34e-4bbe-b341-fa372212029c

📥 Commits

Reviewing files that changed from the base of the PR and between a1506cd and c23d583.

📒 Files selected for processing (2)
  • skill-template/domains/mail.md
  • skills/lark-mail/SKILL.md

Comment thread skills/lark-mail/SKILL.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant