refactor(envvars): consolidate agent env value access

[liangshuo-1]

Tidy up how agent-related env values are read: the read + sanitize now live in one place (internal/envvars), shared by AgentTrace and a new AgentName accessor.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR relocates agent-trace sanitization logic from internal/cmdutil/secheader.go into a new internal/envvars package, introducing AgentName() and AgentTrace() functions backed by a shared sanitizeSingleLine helper. BaseSecurityHeaders() now calls envvars.AgentTrace(), and the local AgentTraceValue() helper along with its tests are removed.

Changes

Env var sanitization relocation

Layer / File(s)	Summary
New envvars constants and sanitized readers internal/envvars/envvars.go, internal/envvars/read.go	Adds CliAgentName constant and new AgentName()/AgentTrace() functions using a shared sanitizeSingleLine helper that trims whitespace, enforces max length, and rejects control characters.
Tests for envvars readers internal/envvars/read_test.go	New test file covering empty/unset env vars, trimming, control-character rejection, and length boundaries for both functions.
Wire BaseSecurityHeaders to envvars.AgentTrace internal/cmdutil/secheader.go, internal/cmdutil/secheader_test.go	Removes local AgentTraceValue() and unused imports; BaseSecurityHeaders() now sources HeaderAgentTrace from envvars.AgentTrace(); corresponding obsolete unit tests are removed and test section renamed.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant BaseSecurityHeaders
  participant envvars

  Caller->>BaseSecurityHeaders: build headers
  BaseSecurityHeaders->>envvars: AgentTrace()
  envvars-->>BaseSecurityHeaders: sanitized value or ""
  BaseSecurityHeaders-->>Caller: headers with HeaderAgentTrace (if non-empty)

Loading

Possibly related PRs

• larksuite/cli#1158: Implements the original HeaderAgentTrace derivation from an agent-trace env var, whose sanitization logic this PR relocates into envvars.AgentTrace().

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is only one sentence and omits the required Summary, Changes, Test Plan, and Related Issues sections.	Rewrite it to match the template with a brief summary, bullet list of changes, test plan, and related issues.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and accurately summarizes the refactor around consolidating agent env value access.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/agent-name-env

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.42%. Comparing base (c45ff56) to head (f2b4bed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files         854      855    +1     
  Lines       88457    88481   +24     
=======================================
+ Hits        65832    65856   +24     
+ Misses      17556    17555    -1     
- Partials     5069     5070    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@f2b4bedb7badceb15b142e267d18ca7ec4b85ef9

🧩 Skill update

npx skills add larksuite/cli#feat/agent-name-env -y -g