Soften Drive cleanup visibility checks - #1761
Closed
yxzhaao wants to merge 2 commits into
Closed
Conversation
Change-Id: I35767f8dff5018dc5b2cda031e1d1efd66b0019d
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change-Id: I42e3f16447dad7b3ec2048a6d8bb7ca72d3d0f03
Contributor
Author
|
Superseded by #1709; moved the Drive cleanup and CLI E2E domain-selection changes into that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
drive +deletesucceeds but meta remains visible after the post-delete wait, report a cleanup warning instead of failing the business E2E.scripts/e2e_scope.shso CI resolves CLI E2E scope from changed files assubset,full, orskip.dry_packages/live_packagesinstead of always running every domain package.Why
Drive delete can be accepted by the server while metadata remains visible briefly because of eventual consistency. Teardown should not fail otherwise-passed business workflows, such as
TestDocs_UpdateWorkflow, when the destructive cleanup command has already succeeded.Live E2E should also stay focused on the business domains touched by a PR. Domain-specific changes now run only matching
tests/cli_e2e/<domain>packages, while shared/runtime/workflow changes conservatively fall back to full coverage and docs-only changes skip CLI E2E.Validation
make script-testbash scripts/e2e_scope.test.shbash scripts/ci-workflow.test.shgo test ./tests/cli_e2e ./tests/cli_e2e/drive -run TestDeleteDriveResourceAndVerify -count=1