Skip to content

Soften Drive cleanup visibility checks - #1761

Closed
yxzhaao wants to merge 2 commits into
larksuite:mainfrom
yxzhaao:drive-cleanup-visibility-warning
Closed

Soften Drive cleanup visibility checks#1761
yxzhaao wants to merge 2 commits into
larksuite:mainfrom
yxzhaao:drive-cleanup-visibility-warning

Conversation

@yxzhaao

@yxzhaao yxzhaao commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Treat Drive cleanup visibility lag differently from delete failures: if drive +delete succeeds but meta remains visible after the post-delete wait, report a cleanup warning instead of failing the business E2E.
  • Keep failed delete commands fatal when the resource still exists.
  • Extend cleanup context to 90s and Drive delete visibility polling to 60s.
  • Add scripts/e2e_scope.sh so CI resolves CLI E2E scope from changed files as subset, full, or skip.
  • Wire both dry-run and live CLI E2E jobs to use resolved dry_packages / live_packages instead of always running every domain package.
  • Add script-level coverage for domain subset, doc/docs expansion, shared-harness full fallback, runtime full fallback, docs-only skip, and skill-domain mapping.

Why

Drive delete can be accepted by the server while metadata remains visible briefly because of eventual consistency. Teardown should not fail otherwise-passed business workflows, such as TestDocs_UpdateWorkflow, when the destructive cleanup command has already succeeded.

Live E2E should also stay focused on the business domains touched by a PR. Domain-specific changes now run only matching tests/cli_e2e/<domain> packages, while shared/runtime/workflow changes conservatively fall back to full coverage and docs-only changes skip CLI E2E.

Validation

  • make script-test
  • bash scripts/e2e_scope.test.sh
  • bash scripts/ci-workflow.test.sh
  • go test ./tests/cli_e2e ./tests/cli_e2e/drive -run TestDeleteDriveResourceAndVerify -count=1

Change-Id: I35767f8dff5018dc5b2cda031e1d1efd66b0019d
@github-actions github-actions Bot added the size/S Low-risk docs, CI, test, or chore only changes label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9356a25e-f8a4-4cc8-a7ae-ea2e2d5c5f36

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Change-Id: I42e3f16447dad7b3ec2048a6d8bb7ca72d3d0f03
@github-actions github-actions Bot added size/L Large or sensitive change across domains or core paths and removed size/S Low-risk docs, CI, test, or chore only changes labels Jul 6, 2026
@yxzhaao

yxzhaao commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #1709; moved the Drive cleanup and CLI E2E domain-selection changes into that PR.

@yxzhaao yxzhaao closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant