feat(slides): add slides chart demo reference#1769
Conversation
📝 WalkthroughWalkthroughThis PR adds a chart demo slide deck and updates planning and reference docs to route supported standard charts to native ChangesChart demo and rendering guidance
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/slides_chart_demo.xml`:
- Line 1: The whiteboard demo slots are empty self-closing placeholders, so the
scatter, bubble, funnel, pareto, waterfall, and combo examples render as blank
cards. Update the `<whiteboard>` instances in slides_chart_demo.xml to include
the actual SVG/Mermaid payloads for those charts, using the existing whiteboard
elements as the locators. For the combo example, either populate it with a real
whiteboard payload or replace it with a native `<chart>` example, since combo is
already supported by the chart contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7c8517b1-c16a-4601-a4ef-2b86c5b67dbb
📒 Files selected for processing (2)
skills/lark-slides/references/slides_chart_demo.xmlskills/lark-slides/references/xml-format-guide.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@9158d8820b0b8a7759d5e71d637086b02a069b20🧩 Skill updatenpx skills add larksuite/cli#feat/slides_chart_demo -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
=======================================
Coverage 74.44% 74.44%
=======================================
Files 860 860
Lines 89859 89859
=======================================
Hits 66897 66897
Misses 17778 17778
Partials 5184 5184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1b7f01f to
c5eb6e7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-slides/references/slides_chart_demo.xml (1)
2-2: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRemove the stray trailing
2.
A literal2after</presentation>makes the XML malformed and will break parsing/loading.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-slides/references/slides_chart_demo.xml` at line 2, Remove the stray trailing literal after the closing presentation tag in the slides_chart_demo XML so the document remains well-formed and parsable. Update the presentation markup to end cleanly at the closing tag, and verify there are no extra characters appended after the root element.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/lark-slides-whiteboard.md`:
- Around line 64-71: The model-path table in the whiteboard reference is too
broad: scatter and funnel visuals must stay on the SVG route and should not be
redirected to Mermaid for any model. Update the guidance around the third step
and the model mapping so that scatter/funnel remain explicitly included in the
SVG path, while only truly Mermaid-friendly decorative/diagram cases use Mermaid
for lower-capability models. Keep the fix anchored in the
“第三步:非原生图表与装饰元素按模型身份选路径” section and the model identity table.
---
Outside diff comments:
In `@skills/lark-slides/references/slides_chart_demo.xml`:
- Line 2: Remove the stray trailing literal after the closing presentation tag
in the slides_chart_demo XML so the document remains well-formed and parsable.
Update the presentation markup to end cleanly at the closing tag, and verify
there are no extra characters appended after the root element.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 93d6ba1c-98c1-4e82-9fc9-0d39ed3ac2eb
📒 Files selected for processing (5)
skills/lark-slides/references/lark-slides-whiteboard.mdskills/lark-slides/references/slides_chart_demo.xmlskills/lark-slides/references/slides_xml_schema_definition.xmlskills/lark-slides/references/xml-format-guide.mdskills/lark-slides/references/xml-schema-quick-ref.md
✅ Files skipped from review due to trivial changes (3)
- skills/lark-slides/references/xml-schema-quick-ref.md
- skills/lark-slides/references/slides_xml_schema_definition.xml
- skills/lark-slides/references/xml-format-guide.md
c5eb6e7 to
9158d88
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/planning-layer.md`:
- Around line 124-148: The chart contract definition is incomplete because it
only requires chartData, but native chart generation also needs chartPlotArea.
Update the planning-layer guidance around chart_contract so the required shape
explicitly includes chartPlotArea, or clearly state in the chart_contract
instructions that XML generation always synthesizes chartPlotArea for native
charts. Reference the chart_contract section and the chart generation rules that
mandate a <chart> element when required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1014a062-6da3-4b44-9fb0-02a36cd323ce
📒 Files selected for processing (7)
skills/lark-slides/references/asset-planning.mdskills/lark-slides/references/lark-slides-whiteboard.mdskills/lark-slides/references/planning-layer.mdskills/lark-slides/references/slides_chart_demo.xmlskills/lark-slides/references/slides_xml_schema_definition.xmlskills/lark-slides/references/xml-format-guide.mdskills/lark-slides/references/xml-schema-quick-ref.md
✅ Files skipped from review due to trivial changes (3)
- skills/lark-slides/references/xml-schema-quick-ref.md
- skills/lark-slides/references/slides_xml_schema_definition.xml
- skills/lark-slides/references/xml-format-guide.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-slides/references/slides_chart_demo.xml
Summary
Add a lark-slides chart demo reference and point the XML format guide to it so agents have a concrete chart XML example to follow.
Changes
slides_chart_demo.xmlcovering native chart examples and SVG-backed whiteboard chart examples.xml-format-guide.mdwith a link to the full demo and a compact column chart snippet.Test Plan
lark-cli <domain> <command>flow works as expectedNot run. This is a documentation/reference-only change, and no build or test command was requested for this turn.
Related Issues
Summary by CodeRabbit
chart_contractfield and stricter native<chart>fallback rules).