fix(base): improve table shortcut behavior & guidance#1803
Merged
zhouyue-bytedance merged 3 commits intoJul 21, 2026
Conversation
|
|
github-actions
Bot
added
domain/base
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesThe PR adds field-write readback guidance and stronger dry-run handling, documents auto-number behavior, and unifies record projection aliases across list, search, and get commands with validation and test coverage. Base field operations
Record projection aliases
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)Field update flowsequenceDiagram
participant CLI as base +field-update
participant DryRun as dryRunFieldUpdate
participant API as Base field API
participant Result as fieldUpdateResult
CLI->>DryRun: parse field JSON
DryRun-->>CLI: validation error or PUT request
CLI->>API: submit update
API-->>Result: field response or no-op error
Result-->>CLI: readback recommendation
Record projection flowsequenceDiagram
participant CLI as Base record command
participant Projection as recordProjectionFields
participant Request as record request builder
participant API as Base records API
CLI->>Projection: read projection flags
Projection-->>CLI: normalized fields or validation error
CLI->>Request: build select_fields or field_id parameters
Request->>API: send record query
API-->>CLI: return records
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/base/base_execute_test.go`:
- Around line 1785-1791: The new “list projection aliases reject ambiguous
inputs” test is only checking an error message substring, but it should assert
typed problem metadata instead. Update the test around
runShortcut/BaseRecordList to use errs.ProblemOf and verify the expected
category, subtype, and param for the mutually exclusive input error, following
the same pattern used by other tests in this file. Preserve any wrapped cause
assertions as needed rather than relying on strings.Contains(err.Error(),
"mutually exclusive").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b62b7211-e3e2-435a-94db-ee1459af23e1
📒 Files selected for processing (14)
shortcuts/base/base_dryrun_ops_test.goshortcuts/base/base_execute_test.goshortcuts/base/base_shortcuts_test.goshortcuts/base/field_ops.goshortcuts/base/field_update.goshortcuts/base/helpers.goshortcuts/base/record_list.goshortcuts/base/record_ops.goshortcuts/base/record_query.goshortcuts/base/record_upsert.goskills/lark-base/references/lark-base-field-json.mdskills/lark-base/references/lark-base-field-update.mdtests/cli_e2e/base/base_field_update_dryrun_test.gotests/cli_e2e/base/base_record_list_dryrun_test.go
huarenmin13
force-pushed
the
table-review-fixes-pr
branch
from
July 9, 2026 12:16
63dde95 to
6b254de
Compare
github-actions
Bot
added
size/M
There was a problem hiding this comment.
🧹 Nitpick comments (2)
shortcuts/base/field_ops.go (1)
214-238: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsolidate
fieldCreateResultandfieldUpdateResultinto a single helper.These two functions are identical except for the
operationstring passed tofieldWriteReadbackRecommendation. Extracting a singlefieldWriteResult(result, submitted, operation)eliminates the duplication and ensures future metadata fields are added in one place.♻️ Proposed consolidation
-func fieldCreateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { - readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, "create") - result["field_get_recommended"] = readbackRecommended - if readbackRecommended { - result["next_step"] = "field_get" - result["verification_hint"] = reason - } else { - result["next_step"] = "done" - result["verification_hint"] = reason - } - return result -} - -func fieldUpdateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { - readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, "update") - result["field_get_recommended"] = readbackRecommended - if readbackRecommended { - result["next_step"] = "field_get" - result["verification_hint"] = reason - } else { - result["next_step"] = "done" - result["verification_hint"] = reason - } - return result -} +func fieldWriteResult(result map[string]interface{}, submitted map[string]interface{}, operation string) map[string]interface{} { + readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, operation) + result["field_get_recommended"] = readbackRecommended + if readbackRecommended { + result["next_step"] = "field_get" + result["verification_hint"] = reason + } else { + result["next_step"] = "done" + result["verification_hint"] = reason + } + return result +}Then update call sites:
- runtime.Out(fieldCreateResult(map[string]interface{}{"field": fields[0], "created": true}, bodies[0]), nil) + runtime.Out(fieldWriteResult(map[string]interface{}{"field": fields[0], "created": true}, bodies[0], "create"), nil)- runtime.Out(fieldUpdateResult(map[string]interface{}{"field": data, "updated": true}, body), nil) + runtime.Out(fieldWriteResult(map[string]interface{}{"field": data, "updated": true}, body, "update"), nil)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/base/field_ops.go` around lines 214 - 238, `fieldCreateResult` and `fieldUpdateResult` are duplicate implementations that only differ by the operation string passed to `fieldWriteReadbackRecommendation`. Extract a shared helper such as `fieldWriteResult(result, submitted, operation)` in `field_ops.go` that sets `field_get_recommended`, `next_step`, and `verification_hint`, then have both existing functions delegate to it with their respective operation values. Update any call sites to use the consolidated helper path where appropriate so future metadata changes only need to be made in one place.shortcuts/base/base_execute_test.go (1)
833-853: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winNoop test doesn't assert typed category/subtype.
errs.ProblemOf(err)here only confirms the error is typed, but doesn't checkCategory/Subtypeas the sibling testTestBaseFieldExecuteUpdateRejectsReformatKeyInJSONdoes. Per path guideline, error-path tests should assert typed metadata (category/subtype/param), not just "is typed."✅ Proposed strengthening
- if _, ok := errs.ProblemOf(err); !ok { + p, ok := errs.ProblemOf(err) + if !ok { t.Fatalf("expected a typed API error, got %T %v", err, err) } + if p.Category == "" || p.Subtype == "" { + t.Fatalf("expected category/subtype set on typed error, got %+v", p) + }As per path instructions: "Error-path tests must assert typed metadata via
errs.ProblemOf(category/subtype/param) and cause preservation, not message substrings alone."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/base/base_execute_test.go` around lines 833 - 853, The no-op API error test only checks that errs.ProblemOf(err) returns a typed error, but it does not verify the typed metadata required by this path. Strengthen TestBaseFieldExecuteUpdateNoopReturnsAPIError by asserting the returned problem’s Category, Subtype, and Param fields via errs.ProblemOf, matching the pattern used in TestBaseFieldExecuteUpdateRejectsReformatKeyInJSON, and keep the existing cause-preservation check if applicable.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@shortcuts/base/base_execute_test.go`:
- Around line 833-853: The no-op API error test only checks that
errs.ProblemOf(err) returns a typed error, but it does not verify the typed
metadata required by this path. Strengthen
TestBaseFieldExecuteUpdateNoopReturnsAPIError by asserting the returned
problem’s Category, Subtype, and Param fields via errs.ProblemOf, matching the
pattern used in TestBaseFieldExecuteUpdateRejectsReformatKeyInJSON, and keep the
existing cause-preservation check if applicable.
In `@shortcuts/base/field_ops.go`:
- Around line 214-238: `fieldCreateResult` and `fieldUpdateResult` are duplicate
implementations that only differ by the operation string passed to
`fieldWriteReadbackRecommendation`. Extract a shared helper such as
`fieldWriteResult(result, submitted, operation)` in `field_ops.go` that sets
`field_get_recommended`, `next_step`, and `verification_hint`, then have both
existing functions delegate to it with their respective operation values. Update
any call sites to use the consolidated helper path where appropriate so future
metadata changes only need to be made in one place.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 695356ce-a34f-472f-bc41-ce1e7f24a33e
📒 Files selected for processing (15)
shortcuts/base/base_dryrun_ops_test.goshortcuts/base/base_execute_test.goshortcuts/base/base_shortcuts_test.goshortcuts/base/field_ops.goshortcuts/base/field_update.goshortcuts/base/helpers.goshortcuts/base/record_list.goshortcuts/base/record_ops.goshortcuts/base/record_query.goshortcuts/base/record_upsert.goskills/lark-base/references/lark-base-field-create.mdskills/lark-base/references/lark-base-field-json.mdskills/lark-base/references/lark-base-field-update.mdtests/cli_e2e/base/base_field_update_dryrun_test.gotests/cli_e2e/base/base_record_list_dryrun_test.go
✅ Files skipped from review due to trivial changes (2)
- shortcuts/base/record_upsert.go
- skills/lark-base/references/lark-base-field-json.md
🚧 Files skipped from review as they are similar to previous changes (4)
- tests/cli_e2e/base/base_record_list_dryrun_test.go
- shortcuts/base/record_list.go
- shortcuts/base/record_query.go
- shortcuts/base/record_ops.go
huarenmin13
force-pushed
the
table-review-fixes-pr
branch
from
July 9, 2026 14:58
6b254de to
5b407f7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
shortcuts/base/field_ops.go (1)
211-259: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsolidate
fieldCreateResultandfieldUpdateResult; drop redundant if/else.Both functions are identical apart from the operation string passed to
fieldWriteReadbackRecommendation, and in each,verification_hintis set toreasonin both branches of theif/else— onlynext_stepactually differs. Consider one shared helper.♻️ Proposed consolidation
-func fieldCreateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { - readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, "create") - result["field_get_recommended"] = readbackRecommended - if readbackRecommended { - result["next_step"] = "field_get" - result["verification_hint"] = reason - } else { - result["next_step"] = "done" - result["verification_hint"] = reason - } - return result -} +func fieldCreateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { + return fieldWriteResult(result, submitted, "create") +} // fieldCreateBatchResult attaches the same top-level readback contract to a // multi-field create. ... func fieldCreateBatchResult(result map[string]interface{}, submitted []map[string]interface{}) map[string]interface{} { ... } -func fieldUpdateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { - readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, "update") - result["field_get_recommended"] = readbackRecommended - if readbackRecommended { - result["next_step"] = "field_get" - result["verification_hint"] = reason - } else { - result["next_step"] = "done" - result["verification_hint"] = reason - } - return result -} +func fieldUpdateResult(result map[string]interface{}, submitted map[string]interface{}) map[string]interface{} { + return fieldWriteResult(result, submitted, "update") +} + +func fieldWriteResult(result map[string]interface{}, submitted map[string]interface{}, operation string) map[string]interface{} { + readbackRecommended, reason := fieldWriteReadbackRecommendation(submitted, operation) + result["field_get_recommended"] = readbackRecommended + result["verification_hint"] = reason + if readbackRecommended { + result["next_step"] = "field_get" + } else { + result["next_step"] = "done" + } + return result +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/base/field_ops.go` around lines 211 - 259, `fieldCreateResult` and `fieldUpdateResult` duplicate the same branching logic, with only the operation passed to `fieldWriteReadbackRecommendation` differing. Refactor them to share a small helper that sets `field_get_recommended`, `next_step`, and `verification_hint` once, and have both functions call it with their respective operation strings; keep `fieldCreateBatchResult` unchanged unless it can use the same helper too.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/base/base_shortcuts_test.go`:
- Around line 1237-1244: The new mutual-exclusivity test for
BaseRecordSearch.Validate should assert the validation error using typed
metadata instead of only matching the message text. Update the test around
BaseRecordSearch.Validate/newBaseTestRuntimeWithArrays to use errs.ProblemOf and
verify the expected category, subtype, and param for the --field-id/--fields
conflict, while also preserving the underlying cause. Keep the substring check
out of the assertion path and follow the same typed-error pattern used by the
other tests in this file/package.
---
Nitpick comments:
In `@shortcuts/base/field_ops.go`:
- Around line 211-259: `fieldCreateResult` and `fieldUpdateResult` duplicate the
same branching logic, with only the operation passed to
`fieldWriteReadbackRecommendation` differing. Refactor them to share a small
helper that sets `field_get_recommended`, `next_step`, and `verification_hint`
once, and have both functions call it with their respective operation strings;
keep `fieldCreateBatchResult` unchanged unless it can use the same helper too.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7bba421d-3020-4054-acd9-e105a81858e4
📒 Files selected for processing (15)
shortcuts/base/base_dryrun_ops_test.goshortcuts/base/base_execute_test.goshortcuts/base/base_shortcuts_test.goshortcuts/base/field_ops.goshortcuts/base/field_update.goshortcuts/base/helpers.goshortcuts/base/record_list.goshortcuts/base/record_ops.goshortcuts/base/record_query.goshortcuts/base/record_upsert.goskills/lark-base/references/lark-base-field-create.mdskills/lark-base/references/lark-base-field-json.mdskills/lark-base/references/lark-base-field-update.mdtests/cli_e2e/base/base_field_update_dryrun_test.gotests/cli_e2e/base/base_record_list_dryrun_test.go
✅ Files skipped from review due to trivial changes (6)
- shortcuts/base/record_upsert.go
- shortcuts/base/field_update.go
- shortcuts/base/record_list.go
- skills/lark-base/references/lark-base-field-json.md
- skills/lark-base/references/lark-base-field-create.md
- skills/lark-base/references/lark-base-field-update.md
🚧 Files skipped from review as they are similar to previous changes (6)
- tests/cli_e2e/base/base_field_update_dryrun_test.go
- shortcuts/base/helpers.go
- shortcuts/base/record_query.go
- tests/cli_e2e/base/base_record_list_dryrun_test.go
- shortcuts/base/record_ops.go
- shortcuts/base/base_dryrun_ops_test.go
Contributor
Author
|
Addressed all current CodeRabbit findings in aee1ec3:
The generic docstring-coverage warning was reviewed; this change adds no exported API, so adding repetitive comments to internal helpers and tests would not improve the public contract. |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Contributor
Author
|
@coderabbitai resume |
✅ Action performedReviews resumed. |
huarenmin13
changed the title
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@729883ca4af0173dfc5637e71f68cd3ff884f999🧩 Skill updatenpx skills add huarenmin13/cli#table-review-fixes-pr -y -g |
zgz2048
reviewed
Jul 13, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/base/base_execute_test.go`:
- Around line 1959-1961: Update both error-path assertions in
shortcuts/base/base_execute_test.go at lines 1959-1961 and 2317-2319 to validate
errs.ProblemOf(err) has CategoryValidation and SubtypeInvalidArgument, while
retaining the existing “duplicate field id” message-substring check. Follow the
typed error assertion pattern already used elsewhere in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a19f822-e7c7-4abc-8a5f-8c29a5bda81c
📒 Files selected for processing (10)
shortcuts/base/base_dryrun_ops_test.goshortcuts/base/base_execute_test.goshortcuts/base/base_shortcuts_test.goshortcuts/base/field_ops.goshortcuts/base/record_get.goshortcuts/base/record_list.goshortcuts/base/record_ops.goshortcuts/base/record_query.goshortcuts/base/record_search.goskills/lark-base/references/lark-base-field-update.md
🚧 Files skipped from review as they are similar to previous changes (4)
- shortcuts/base/base_dryrun_ops_test.go
- skills/lark-base/references/lark-base-field-update.md
- shortcuts/base/record_query.go
- shortcuts/base/field_ops.go
github-actions
Bot
added
size/L
There was a problem hiding this comment.
🧹 Nitpick comments (1)
shortcuts/base/base_execute_test.go (1)
2324-2368: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove superseded duplicate tests and align
getduplicate projection coverage.This new parameterized test fully covers the validation previously tested in
t.Run("get rejects mixed field-id and json select_fields")(lines 2396-2402), making the older test redundant.Additionally, consider adding a similar parameterized test for
getto verify that duplicate canonical and alias projections are rejected consistently, matching the new coverage you added forlistat line 1946. This would replace the older un-parameterizedt.Run("get rejects duplicate field ids")test (lines 2380-2386).♻️ Proposed test removal and addition
Delete the redundant
get rejects mixed field-id and json select_fieldsandget rejects duplicate field idstests, and add the following parameterized test:t.Run("get canonical and alias projections reject duplicates consistently", func(t *testing.T) { tests := []struct { name string args []string param string }{ {name: "canonical", args: []string{"--field-id", "Name", "--field-id", "Name"}, param: "--field-id"}, {name: "fields alias", args: []string{"--fields", `["Name","Name"]`}, param: "--fields"}, {name: "field names alias", args: []string{"--field-names", "Name", "--field-names", "Name"}, param: "--field-names"}, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { factory, stdout, _ := newExecuteFactory(t) args := append([]string{"+record-get", "--base-token", "app_x", "--table-id", "tbl_x", "--record-id", "rec_1"}, tc.args...) err := runShortcut(t, BaseRecordGet, args, factory, stdout) if err == nil { t.Fatal("expected duplicate projection error, got nil") } p, ok := errs.ProblemOf(err) if !ok || p.Category != errs.CategoryValidation || p.Subtype != errs.SubtypeInvalidArgument { t.Fatalf("expected invalid-argument validation problem, got %T %v", err, err) } var validationErr *errs.ValidationError if !errors.As(err, &validationErr) { t.Fatalf("expected ValidationError, got %T %v", err, err) } if validationErr.Param != tc.param || len(validationErr.Params) != 1 || validationErr.Params[0].Name != tc.param { t.Fatalf("param/params=%q/%#v, want %q", validationErr.Param, validationErr.Params, tc.param) } if !strings.Contains(err.Error(), "duplicate field id") { t.Fatalf("err=%v", err) } }) } })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/base/base_execute_test.go` around lines 2324 - 2368, In the get test suite, remove the superseded “get rejects mixed field-id and json select_fields” and “get rejects duplicate field ids” cases. Add a parameterized test alongside the existing get projection tests covering duplicate canonical, fields-alias, and field-names-alias inputs, asserting each returns an invalid-argument ValidationError with the corresponding parameter metadata and duplicate-field error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@shortcuts/base/base_execute_test.go`:
- Around line 2324-2368: In the get test suite, remove the superseded “get
rejects mixed field-id and json select_fields” and “get rejects duplicate field
ids” cases. Add a parameterized test alongside the existing get projection tests
covering duplicate canonical, fields-alias, and field-names-alias inputs,
asserting each returns an invalid-argument ValidationError with the
corresponding parameter metadata and duplicate-field error.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1e3f98c9-4b6a-4bc4-9354-b9f15ac77634
📒 Files selected for processing (3)
shortcuts/base/base_execute_test.goshortcuts/base/helpers_test.goshortcuts/base/record_ops.go
🚧 Files skipped from review as they are similar to previous changes (1)
- shortcuts/base/record_ops.go
huarenmin13
force-pushed
the
table-review-fixes-pr
branch
from
July 17, 2026 12:01
0d80e70 to
7462992
Compare
github-actions
Bot
added
size/M
huarenmin13
force-pushed
the
table-review-fixes-pr
branch
from
July 17, 2026 12:30
7462992 to
2af257b
Compare
github-actions
Bot
added
size/L
huarenmin13
force-pushed
the
table-review-fixes-pr
branch
from
July 17, 2026 13:12
2af257b to
65c28c1
Compare
1. Treat select_fields:null as omitted before record-get projection conflict checks. 2. Add dry-run E2E coverage for omitted and flag-projection cases. ```ai-signature 改动范围: shortcuts/base/record_ops.go 与 tests/cli_e2e/base/base_record_list_dryrun_test.go，仅调整 record-get 对 JSON null projection 的处理和回归验证 思考过程: 保持现有 projection normalizer 与互斥规则不变，只在读取 select_fields 后把 null 与缺失键等价，避免扩大到字段上限或 auto_number 行为 改动原因: PR 1803 声明 list search get 使用统一 projection contract，但 record-get 对 select_fields:null 仍返回 invalid_argument，与 record-search 不一致 Break Change: 否；仅将此前失败的 select_fields:null 输入规范化为省略，并保留 flag projection ``` Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local> AI-SHA256: b3d37c6c026f0215d994bc7c9bad4c65caee1b3bc2e9584ff20403a4d06969c3
1. Centralize Base dry-run environment setup, timeout handling, command execution,
and exit-code assertions in runBaseDryRun.
2. Migrate record projection and field update dry-run tests without changing their contract assertio
ns or covered scenarios.
3. Verify all 11 affected top-level tests and four projection subtests with the current-HEAD binary
under race mode.
```ai-signature
改动范围: tests/cli_e2e/base/helpers_test.go、base_record_list_dryrun_test.go 与 base_field_update_dryrun_test.go，仅收敛 dry-run 测试执行脚手架
思考过程: 复用现有测试基础设施，把环境隔离、超时、dry-run 参数、命令执行和退出码断言集中到一个 helper，同时保留每个用例的业务断言
改动原因: PR 1803 的新增测试占主要改动量，其中 11 处重复执行模板可安全去重，降低评审体量而不削减 P1 或 P2 场景覆盖
Break Change: 否
```
Co-authored-by: BASE Infra Harness <ai@base-infra-harness.noreply.local>
AI-SHA256: ee39fef8497de65ecea1a0f22d9d87f1622c3f69daa5743ba7fd4c874dbb2ed3
zhouyue-bytedance
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve Base shortcut behavior and guidance for field writes and record projection. This revision rebuilds the PR's effective diff on the latest
mainand includes the follow-ups from the previous review pass.Changes
field_get_recommended,next_step, andverification_hintguidance after successful field writes.+field-updaterecommends+field-getbecause the update response cannot reveal the field's previous type, gives a dedicated hint for returned/submitted type mismatches, and documents how to verify state after a no-op API error.auto_numberupdates on the v3 field-update path and document the API behavior for applying updated numbering rules to existing values.--field-id, compatible hidden--fields/--field-namesaliases, shared normalization, duplicate/limit/mutual-exclusion checks, and accurate parameter attribution in structured errors. The legacy--field-namesCSV/repeated semantics, quoted commas, and literal@-prefixed names remain supported.Review feedback
auto_numberstyle.rulesguidance.--field-namesCSV contract, including quoted commas and literal@-prefixed field names.record-search --jsonconflict errors.maxguidance and normalized explicitselect_fields: nullto omission.Test Plan
make unit-test(full repository unit matrix with race)make vetmake fmt-checkgo mod tidyleavesgo.mod/go.sumunchangedgo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=upstream/main(0 issues)go test -count=1 ./shortcuts/basego test -race -count=1 ./shortcuts/basego build -o /private/tmp/lark-cli-pr1803-sync-v2 .gopls checkon all changed production Go filesauto_number, Rating, list/search/get aliases, quoted CSV, literal@names, JSON conflicts, and flag-like field namesgit diff --checkRelated Issues