fix(drive): abort push on parent sibling limit - #1813
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughIntroduces handling for Lark Drive error code 1062507 (parent sibling/child-count limit). Adds classification metadata mapping the code to quota-exceeded API error, marks it terminal in drive push batch failure handling with a corrective hint, adds a regression test, updates test matrix, and documents the error in reference docs. ChangesParent Sibling Limit Error Classification
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Test as DrivePushTest
participant Push as DrivePushCommand
participant Classifier as driveClassifyBatchFailure
participant API as MockedLarkAPI
Test->>Push: run push command
Push->>API: create_folder for "a"
API-->>Push: error code 1062507
Push->>Classifier: classify failure
Classifier-->>Push: Class=parent_sibling_limit, Terminal=true, Hint
Push-->>Test: PartialFailureError (failed=1, aborted=true)
Push--x Push: skip create_folder for "b"
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1511e41d5741e5a5579c8d1b57013f7e1291264d🧩 Skill updatenpx skills add larksuite/cli#codex/drive-push-parent-sibling-limit -y -g |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
=======================================
Coverage 74.44% 74.44%
=======================================
Files 860 860
Lines 89855 89859 +4
=======================================
+ Hits 66891 66897 +6
+ Misses 17780 17778 -2
Partials 5184 5184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Tests
Notes
Summary by CodeRabbit
Bug Fixes
Documentation