feat: add minutes permission application shortcut#1876
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
📝 WalkthroughWalkthroughAdds ChangesMinutes permission application
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant MinutesShortcut
participant MinutesAPI
CLI->>MinutesShortcut: provide minute-token and perm
MinutesShortcut->>MinutesAPI: POST permissions/apply
MinutesAPI-->>MinutesShortcut: return permission result
MinutesShortcut-->>CLI: print minute_token and perm
Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
==========================================
+ Coverage 74.60% 74.66% +0.06%
==========================================
Files 877 878 +1
Lines 91720 91764 +44
==========================================
+ Hits 68426 68520 +94
+ Misses 17981 17930 -51
- Partials 5313 5314 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
423436b to
492b93a
Compare
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@492b93a501d45621546c565aa8359851ebe17d51🧩 Skill updatenpx skills add larksuite/cli#feat/one-click-minutes-permission -y -g |
Summary
Add a user-authenticated
minutes +apply-permissionshortcut for requesting view or edit access to a Lark Minute. Permission-denied paths now provide an actionable recovery command while preserving the requirement for explicit user consent before an application is sent.Changes
minutes +apply-permission --minute-token <token> --perm view|editand register the requiredminutes:permission:applyscope.Test Plan
make buildmake unit-testfeature suites passed; the initial full run hit unrelated temporary-directory cleanup races, and both affected packages passed on an immediate race-enabled retry.go test -race -gcflags="all=-N -l" -count=1 ./internal/qualitygate/diff ./internal/qualitygate/publiccontentgo test ./tests/cli_e2e/minutes -run TestMinutesApplyPermission -count=1go vet ./...gofmt -l .go mod tidyproduced no changes.go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/mainreported 0 issues.Related Issues
Summary by CodeRabbit
New Features
minutes +apply-permissionto request view or edit access for a minute.Improvements
Tests