Skip to content

docs(sheets): use English placeholder in table-get guidance#1936

Merged
zhengzhijiej-tech merged 1 commit into
mainfrom
fix/table-get-na-example
Jul 17, 2026
Merged

docs(sheets): use English placeholder in table-get guidance#1936
zhengzhijiej-tech merged 1 commit into
mainfrom
fix/table-get-na-example

Conversation

@zhengzhijiej-tech

@zhengzhijiej-tech zhengzhijiej-tech commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the Chinese placeholder example in +table-get guidance with N/A.
  • Keep the implementation comment and regression test aligned with the documented example.

Validation

  • go test ./shortcuts/sheets

Summary by CodeRabbit

  • Documentation
    • Updated table shortcut examples to use “N/A” when describing mixed-type column values.
  • Tests
    • Updated the corresponding mixed number-and-text test example to use “N/A”; expected behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff58b29a-6ff4-425a-9c42-d68d559eab43

📥 Commits

Reviewing files that changed from the base of the PR and between 27df16d and fa8675e.

📒 Files selected for processing (2)
  • shortcuts/sheets/lark_sheet_table_io.go
  • shortcuts/sheets/lark_sheet_table_io_test.go

📝 Walkthrough

Walkthrough

Updates mixed-type column inference examples from “暂无” to “N/A” in shortcut documentation, an inline comment, and the associated test. Executable inference behavior remains unchanged.

Changes

Mixed-Type Example Update

Layer / File(s) Summary
Update mixed-type examples and validation
shortcuts/sheets/lark_sheet_table_io.go, shortcuts/sheets/lark_sheet_table_io_test.go
Documentation and the mixed numeric-plus-text test case now use “N/A”; the test continues to expect a string result.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR’s main change: replacing the table-get placeholder with an English example.
Description check ✅ Passed The description covers the summary and validation, but it omits the template's explicit Changes and Related Issues sections.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/table-get-na-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@fa8675edd1a94a92a9012a553e99226ea129ed5a

🧩 Skill update

npx skills add larksuite/cli#fix/table-get-na-example -y -g

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.96%. Comparing base (27df16d) to head (fa8675e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files         892      892           
  Lines       94077    94077           
=======================================
  Hits        70529    70529           
  Misses      18137    18137           
  Partials     5411     5411           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zhengzhijiej-tech
zhengzhijiej-tech merged commit 6c14c42 into main Jul 17, 2026
53 of 55 checks passed
@zhengzhijiej-tech
zhengzhijiej-tech deleted the fix/table-get-na-example branch July 17, 2026 09:01
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 17, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants