feat(drive): support importing .png files as slides#1960
Closed
tianyouskrrr wants to merge 1 commit into
Closed
Conversation
Adds .png to the allowed drive-import extension list (mapped to slides), updates validation error messages and skill docs, and covers it with a unit test plus a dry-run e2e test.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughChangesPNG Drive import
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant DriveImportCLI
participant UploadAPI
participant ImportTaskAPI
User->>DriveImportCLI: drive +import screenshot.png --type slides
DriveImportCLI->>UploadAPI: initialize PNG upload
UploadAPI-->>DriveImportCLI: upload metadata
DriveImportCLI->>ImportTaskAPI: create Slides import task
ImportTaskAPI-->>DriveImportCLI: import task request
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Per team decision: this branch is maintained for Doubao's exclusive use, not merged into lark-cli main. Keeping feat/drive-import-png as a live branch, closing this PR without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit
New Features
.pngfiles as Slides.Documentation
Tests