fix(slides): clarify xml-text-overlap-lint error for positional argument #1986
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe XML text overlap lint CLI now advises using ChangesCLI argument guidance
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/scripts/xml_text_overlap_lint.py`:
- Line 69: Replace the fullwidth comma in the unexpected-argument error emitted
by fail with a standard comma followed by a space. Update the matching assertion
in skills/lark-slides/scripts/xml_text_overlap_lint_test.py lines 50-53 to
expect the exact revised message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bdab7a2e-17ad-4e2e-ac97-427fd3a0706e
📒 Files selected for processing (2)
skills/lark-slides/scripts/xml_text_overlap_lint.pyskills/lark-slides/scripts/xml_text_overlap_lint_test.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 75.05% 75.05%
=======================================
Files 901 901
Lines 95391 95391
=======================================
Hits 71591 71591
Misses 18307 18307
Partials 5493 5493 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@df2b9d37742e40a42b0351cdfe9cc44a96b571df🧩 Skill updatenpx skills add larksuite/cli#fix/clarify_lint_flag -y -g |
Description:
Summary
--input <path>, the CLI error message now explicitly hints,need --input, making the required flag obvious instead of a bare "unexpected argument" message.methods).
Test plan
python3 -m unittest xml_text_overlap_lint_test -v— 53 tests passSummary by CodeRabbit
Bug Fixes
--inputoption.Tests
1, outputs no stdout, and reports the updated “unexpected argument” error with the--inputsuggestion.