Skip to content

docs(skill): clarify scope handling for query expansion#2030

Merged
fangshuyu-768 merged 2 commits into
mainfrom
docs/preserve-search-scope-filters
Jul 23, 2026
Merged

docs(skill): clarify scope handling for query expansion#2030
fangshuyu-768 merged 2 commits into
mainfrom
docs/preserve-search-scope-filters

Conversation

@fangshuyu-768

@fangshuyu-768 fangshuyu-768 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Clarify the existing lark-drive content-search guidance for query expansion. User-specified scope filters should normally remain in place, and agents should explain the reason and get confirmation before broadening the search scope.

Changes

  • Add one sentence to the existing query-expansion guidance covering knowledge spaces, folders, chats, people, time ranges, and resource types.

Test Plan

  • node scripts/skill-format-check/index.js skills
  • Manual forward-test of a knowledge-base-scoped search with no matching results

Related Issues

  • None

@github-actions github-actions Bot added domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact labels Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

更新 Lark Drive 搜索指南,规定扩展 query 时优先保留用户明确指定的检索范围;确需放宽范围时,先向用户说明并征得确认。

Changes

搜索范围约束

Layer / File(s) Summary
范围约束与扩展确认
skills/lark-drive/references/lark-drive-search.md
新增规则,要求扩展检索范围时保留用户指定的空间、文件夹、群聊、人员、时间和类型等过滤条件;确需放宽时先征得用户确认。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • larksuite/cli#864:更新同一搜索指南中的 query 扩展、查询边界和过滤条件规则。

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed Title is concise and accurately summarizes the query-expansion scope-handling update.
Description check ✅ Passed Description follows the template and includes Summary, Changes, Test Plan, and Related Issues sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/preserve-search-scope-filters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-drive/references/lark-drive-search.md`:
- Around line 100-108: 更新“保留用户指定的检索范围”部分,明确处理同时指定 --space-ids 与 --folder-tokens
的情况:不要生成同时包含两者的无效命令,也不要静默删除或替换任一过滤条件;应请求用户选择范围,或分别执行并明确标注的独立搜索。
- Line 222: 更新该“证据核验”流程,按请求类型限定无结果时的行为:内容问答可扩展语义关键词并按需翻页;列表/统计请求必须继续使用空
query,仅在用户明确要求完整结果或继续查询时翻页。无结果且未满足这些条件时,直接如实报告未找到,不得自动扩大 query 或增加页数。
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fa5efc19-7ea0-4ee9-918a-c3d31a7bcd42

📥 Commits

Reviewing files that changed from the base of the PR and between c74d9b6 and c832186.

📒 Files selected for processing (1)
  • skills/lark-drive/references/lark-drive-search.md

Comment thread skills/lark-drive/references/lark-drive-search.md Outdated
Comment thread skills/lark-drive/references/lark-drive-search.md Outdated
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@6a22cefd4ca2022d5b008f6d943048f7b2c287e0

🧩 Skill update

npx skills add larksuite/cli#docs/preserve-search-scope-filters -y -g

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.06%. Comparing base (c74d9b6) to head (6a22cef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   75.07%   75.06%   -0.01%     
==========================================
  Files         902      905       +3     
  Lines       95950    96048      +98     
==========================================
+ Hits        72031    72101      +70     
- Misses      18380    18397      +17     
- Partials     5539     5550      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fangshuyu-768 fangshuyu-768 changed the title docs(skill): preserve scoped search filters docs(skill): clarify scope handling for query expansion Jul 23, 2026
@fangshuyu-768
fangshuyu-768 merged commit 70424c4 into main Jul 23, 2026
43 of 101 checks passed
@fangshuyu-768
fangshuyu-768 deleted the docs/preserve-search-scope-filters branch July 23, 2026 10:35
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 24, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/ccm PR touches the ccm domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants