Skip to content

docs(calendar): confirm scope before editing recurring events - #2119

Merged
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-recurring-confirm-scope
Jul 30, 2026
Merged

docs(calendar): confirm scope before editing recurring events#2119
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-recurring-confirm-scope

Conversation

@calendar-assistant

@calendar-assistant calendar-assistant commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

When editing a recurring event with an ambiguous scope (e.g. "add a meeting room to tomorrow's event"), the skill previously defaulted to the single-instance ("this event only") behavior, so the agent never asked the user which scope they meant. This change makes scope confirmation a pre-routing gate.

Changes

  • Promote the recurring-event rule to a gate above the pre-condition routing table, so it is read before entering any specific operation flow (schedule-meeting / update / etc.).
  • Require confirming the scope (this event / all / this-and-following) when the user is ambiguous, instead of silently defaulting to this-event-only.
  • Remove the redundant and conflicting "edit existing event" row that hard-coded locating a single instance event_id — that default was the root cause of the missed confirmation.
  • Add the "add a meeting room to tomorrow's event (recurring)" example to the intent-mapping table in lark-calendar-recurring.md as a concrete "scope unclear → must ask" case.

Test Plan

  • Unit tests pass
  • Docs-only change to skills/lark-calendar/SKILL.md and references/lark-calendar-recurring.md; verified rendered Markdown and internal links

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Clarified handling for recurring calendar events when the requested scope is unspecified.
    • Users are now prompted to choose whether changes apply to only this occurrence, all occurrences, or this and future occurrences.
    • Added guidance for recurring events when adding a meeting room to an event.

Promote the recurring-event rule to a pre-routing gate so it is read
before the specific operation flow, and require confirming the scope
(this event / all / this-and-following) when the user is ambiguous
instead of defaulting to this-event-only. Removes the redundant and
conflicting "edit existing event" row that hard-coded the single-
instance default.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eb92a90e-463e-46ca-b402-499f9c5d2a84

📥 Commits

Reviewing files that changed from the base of the PR and between 4a16139 and 7d650d0.

📒 Files selected for processing (2)
  • skills/lark-calendar/SKILL.md
  • skills/lark-calendar/references/lark-calendar-recurring.md

📝 Walkthrough

Walkthrough

Changes

Recurring calendar guidance

Layer / File(s) Summary
Scope confirmation rules
skills/lark-calendar/SKILL.md, skills/lark-calendar/references/lark-calendar-recurring.md
Recurring schedule operations now require confirmation of “仅此次/全部/此次及后续” when the requested scope is unspecified. The prerequisite table was narrowed to retain scheduling, lookup, field-update, and attendee-management guidance.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • larksuite/cli#1269: Updates recurring-schedule routing and scope handling in the same calendar skill documentation.
  • larksuite/cli#1723: Aligns recurring-calendar documentation around confirming operation scope.

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: confirming scope before editing recurring events.
Description check ✅ Passed The description matches the template with Summary, Changes, Test Plan, and Related Issues sections and provides the key details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/calendar-recurring-confirm-scope

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@7d650d026a5e9831dda0110085de875442744222

🧩 Skill update

npx skills add larksuite/cli#docs/calendar-recurring-confirm-scope -y -g

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.24%. Comparing base (a575a8b) to head (7d650d0).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   75.25%   75.24%   -0.01%     
==========================================
  Files         916      916              
  Lines       97173    97255      +82     
==========================================
+ Hits        73123    73175      +52     
- Misses      18437    18463      +26     
- Partials     5613     5617       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calendar-assistant
calendar-assistant merged commit fa9c30c into main Jul 30, 2026
34 of 42 checks passed
@calendar-assistant
calendar-assistant deleted the docs/calendar-recurring-confirm-scope branch July 30, 2026 13:59
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 31, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants