Skip to content

docs(slides): temporarily route skill guidance back to +replace-pages - #2187

Merged
tianyouskrrr merged 3 commits into
mainfrom
docs/slides-hold-skill-on-replace-pages
Aug 4, 2026
Merged

docs(slides): temporarily route skill guidance back to +replace-pages#2187
tianyouskrrr merged 3 commits into
mainfrom
docs/slides-hold-skill-on-replace-pages

Conversation

@tianyouskrrr

@tianyouskrrr tianyouskrrr commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

What this changes

Partially reverts the skill portion of #2143: the lark-slides skill routes whole-page edits back to +replace-pages, and the +update-slide reference page is temporarily removed from the skill.

No binary change. Both shortcuts remain available; only the default skill guidance changes.

Why

The skill guidance is temporarily returning to the established compatibility path for whole-page edits.

Details

  • SKILL.md / lark-slides-edit-workflows.md: route single-page and multi-page whole-page edits to +replace-pages.
  • references/lark-slides-replace-pages.md: restore the reference page while preserving subsequent documentation updates.
  • references/lark-slides-update-slide.md: remove it from the skill temporarily.
  • Shortcut implementations and tests remain unchanged.

Follow-up

Restore the +update-slide skill guidance when it is ready to become the default path.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Lark Slides guidance now uses +replace-pages for broad or multi-page rewrites. New documentation defines its input, validation, dry-run, execution, and partial-failure behavior. Local edits continue to use +replace-slide.

Changes

Lark Slides replacement workflow

Layer / File(s) Summary
Document the +replace-pages command
skills/lark-slides/references/lark-slides-replace-pages.md
Adds command parameters, complete slide XML input rules, validation, dry-run behavior, result statuses, and partial-failure handling.
Route full-page rebuilds through +replace-pages
skills/lark-slides/references/lark-slides-edit-workflows.md
Updates the workflow decision tree and documentation links.
Update skill editing rules
skills/lark-slides/SKILL.md
Changes linting, shortcuts, references, and broad rewrite guidance to +replace-pages. Retains +replace-slide for local edits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: domain/ccm

Suggested reviewers: fangshuyu-768

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main documentation change: routing slide skill guidance back to +replace-pages.
Description check ✅ Passed The description clearly covers scope, rationale, affected files, unchanged implementations, and follow-up, but it omits the template headings and explicit test plan.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/slides-hold-skill-on-replace-pages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Around line 84-88: 将描述 replaced、create_failed 和 delete_failed 的状态说明标题明确改为
results[].status,表明这些是每页结果的状态字段;保留各状态含义不变,并与文档前面定义的顶层 status 区分开。

In `@skills/lark-slides/SKILL.md`:
- Around line 108-114: Update the +replace-pages guidance in the “编辑已有幻灯片页面”
workflow to explicitly lint every page’s content from the --pages `@pages.json`
envelope before submission. Document an extraction loop that writes each item’s
content XML to a local file and runs scripts/xml_text_overlap_lint.py --input on
each file, requiring summary.error_count to be 0, or extend the lint script to
accept the pages envelope while preserving the existing input mode.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 049cdf46-77a2-45cf-aa6c-159eceed047a

📥 Commits

Reviewing files that changed from the base of the PR and between 3516952 and 27a5a9e.

📒 Files selected for processing (4)
  • skills/lark-slides/SKILL.md
  • skills/lark-slides/references/lark-slides-edit-workflows.md
  • skills/lark-slides/references/lark-slides-replace-pages.md
  • skills/lark-slides/references/lark-slides-update-slide.md
💤 Files with no reviewable changes (1)
  • skills/lark-slides/references/lark-slides-update-slide.md

Comment thread skills/lark-slides/references/lark-slides-replace-pages.md
Comment thread skills/lark-slides/SKILL.md Outdated
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@2303c54e11591de56e7825c24516f000404c7dcb

🧩 Skill update

npx skills add larksuite/cli#docs/slides-hold-skill-on-replace-pages -y -g

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
skills/lark-slides/references/lark-slides-replace-pages.md (1)

65-79: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the success example internally consistent.

pages_count, summary.total, and summary.replaced are 2, but results contains only one entry. Add the second per-page result or change all counts to 1.

Proposed fix
     {
       "old_slide_id": "old3",
       "new_slide_id": "new3",
       "status": "replaced"
+    },
+    {
+      "old_slide_id": "old4",
+      "new_slide_id": "new4",
+      "status": "replaced"
     }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/lark-slides/references/lark-slides-replace-pages.md` around lines 65 -
79, Make the success response example consistent by adding the missing second
per-page entry to results, matching pages_count and summary counts of 2;
preserve the existing replacement result structure and identifiers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Line 6: Keep the compatibility warning, including any blank lines between its
paragraphs, within a single blockquote by prefixing the blank line with the
blockquote marker; ensure the warning is not split into multiple blockquote
blocks.

---

Outside diff comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Around line 65-79: Make the success response example consistent by adding the
missing second per-page entry to results, matching pages_count and summary
counts of 2; preserve the existing replacement result structure and identifiers.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c53d9bb-4cfe-43c8-8e90-64ea6e8d4436

📥 Commits

Reviewing files that changed from the base of the PR and between 27a5a9e and e699e82.

📒 Files selected for processing (2)
  • skills/lark-slides/SKILL.md
  • skills/lark-slides/references/lark-slides-replace-pages.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-slides/SKILL.md

Comment thread skills/lark-slides/references/lark-slides-replace-pages.md

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
skills/lark-slides/references/lark-slides-replace-pages.md (1)

95-95: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Correct the pages.json workflow wording.

Line 95 says to create a file containing only slide_id. Lines 23 and 46 require every item to also contain content with complete <slide>...</slide> XML. The documented file will fail --validate-only and normal execution. Require both slide_id and content, or document a separate dry-run-only schema.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/lark-slides/references/lark-slides-replace-pages.md` at line 95,
Update the pages.json workflow wording near the dry-run/validation step to
require each item to include both slide_id and complete content containing the
<slide>...</slide> XML, matching the schema described elsewhere. Do not instruct
users to create a slide_id-only file unless explicitly documenting it as a
separate dry-run-only schema.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Line 95: Update the pages.json workflow wording near the dry-run/validation
step to require each item to include both slide_id and complete content
containing the <slide>...</slide> XML, matching the schema described elsewhere.
Do not instruct users to create a slide_id-only file unless explicitly
documenting it as a separate dry-run-only schema.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a754824-4ed6-42da-9861-b12e3ced3ab9

📥 Commits

Reviewing files that changed from the base of the PR and between e699e82 and 818a556.

📒 Files selected for processing (3)
  • skills/lark-slides/SKILL.md
  • skills/lark-slides/references/lark-slides-edit-workflows.md
  • skills/lark-slides/references/lark-slides-replace-pages.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-slides/references/lark-slides-edit-workflows.md

…-page rollout completes

Partially reverts the skill portion of #2143 (56fd29e). lark-cli now ships
+update-slide, but the backend capability it depends on is still rolling out;
on environments without it every call answers an invalid-param error. The skill
was routing all whole-page and multi-page edits there, which turns a staged
backend rollout into a hard failure for every agent that follows the guidance.

Only the guidance moves: whole-page work routes to +replace-pages again, its
reference page is restored (with the SML namespace examples migrated to https,
a tree-wide change that landed while the page was deleted), and
lark-slides-update-slide.md is removed so nothing steers a caller to a command
the backend may refuse.

The binary is untouched. +update-slide stays available for environments that
already have the capability, and +replace-pages keeps working everywhere.
Re-apply the skill routing by reverting this commit once the rollout completes.
@tianyouskrrr
tianyouskrrr force-pushed the docs/slides-hold-skill-on-replace-pages branch from 818a556 to 2303c54 Compare August 4, 2026 14:26
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.72%. Comparing base (3516952) to head (2303c54).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2187   +/-   ##
=======================================
  Coverage   75.72%   75.72%           
=======================================
  Files         944      944           
  Lines      100355   100355           
=======================================
  Hits        75994    75994           
  Misses      18565    18565           
  Partials     5796     5796           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tianyouskrrr
tianyouskrrr requested a review from ethan-zhx August 4, 2026 14:37
@tianyouskrrr tianyouskrrr self-assigned this Aug 4, 2026
@tianyouskrrr tianyouskrrr changed the title docs(slides): route skill guidance back to +replace-pages until whole-page rollout completes docs(slides): temporarily route skill guidance back to +replace-pages Aug 4, 2026
@tianyouskrrr
tianyouskrrr merged commit fb944d2 into main Aug 4, 2026
43 checks passed
@tianyouskrrr
tianyouskrrr deleted the docs/slides-hold-skill-on-replace-pages branch August 4, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants