docs(slides): temporarily route skill guidance back to +replace-pages - #2187
Conversation
📝 WalkthroughWalkthroughThe Lark Slides guidance now uses ChangesLark Slides replacement workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Around line 84-88: 将描述 replaced、create_failed 和 delete_failed 的状态说明标题明确改为
results[].status,表明这些是每页结果的状态字段;保留各状态含义不变,并与文档前面定义的顶层 status 区分开。
In `@skills/lark-slides/SKILL.md`:
- Around line 108-114: Update the +replace-pages guidance in the “编辑已有幻灯片页面”
workflow to explicitly lint every page’s content from the --pages `@pages.json`
envelope before submission. Document an extraction loop that writes each item’s
content XML to a local file and runs scripts/xml_text_overlap_lint.py --input on
each file, requiring summary.error_count to be 0, or extend the lint script to
accept the pages envelope while preserving the existing input mode.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 049cdf46-77a2-45cf-aa6c-159eceed047a
📒 Files selected for processing (4)
skills/lark-slides/SKILL.mdskills/lark-slides/references/lark-slides-edit-workflows.mdskills/lark-slides/references/lark-slides-replace-pages.mdskills/lark-slides/references/lark-slides-update-slide.md
💤 Files with no reviewable changes (1)
- skills/lark-slides/references/lark-slides-update-slide.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@2303c54e11591de56e7825c24516f000404c7dcb🧩 Skill updatenpx skills add larksuite/cli#docs/slides-hold-skill-on-replace-pages -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-slides/references/lark-slides-replace-pages.md (1)
65-79: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMake the success example internally consistent.
pages_count,summary.total, andsummary.replacedare2, butresultscontains only one entry. Add the second per-page result or change all counts to1.Proposed fix
{ "old_slide_id": "old3", "new_slide_id": "new3", "status": "replaced" + }, + { + "old_slide_id": "old4", + "new_slide_id": "new4", + "status": "replaced" }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-slides/references/lark-slides-replace-pages.md` around lines 65 - 79, Make the success response example consistent by adding the missing second per-page entry to results, matching pages_count and summary counts of 2; preserve the existing replacement result structure and identifiers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Line 6: Keep the compatibility warning, including any blank lines between its
paragraphs, within a single blockquote by prefixing the blank line with the
blockquote marker; ensure the warning is not split into multiple blockquote
blocks.
---
Outside diff comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Around line 65-79: Make the success response example consistent by adding the
missing second per-page entry to results, matching pages_count and summary
counts of 2; preserve the existing replacement result structure and identifiers.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c53d9bb-4cfe-43c8-8e90-64ea6e8d4436
📒 Files selected for processing (2)
skills/lark-slides/SKILL.mdskills/lark-slides/references/lark-slides-replace-pages.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-slides/SKILL.md
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-slides/references/lark-slides-replace-pages.md (1)
95-95: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winCorrect the
pages.jsonworkflow wording.Line 95 says to create a file containing only
slide_id. Lines 23 and 46 require every item to also containcontentwith complete<slide>...</slide>XML. The documented file will fail--validate-onlyand normal execution. Require bothslide_idandcontent, or document a separate dry-run-only schema.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-slides/references/lark-slides-replace-pages.md` at line 95, Update the pages.json workflow wording near the dry-run/validation step to require each item to include both slide_id and complete content containing the <slide>...</slide> XML, matching the schema described elsewhere. Do not instruct users to create a slide_id-only file unless explicitly documenting it as a separate dry-run-only schema.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/lark-slides/references/lark-slides-replace-pages.md`:
- Line 95: Update the pages.json workflow wording near the dry-run/validation
step to require each item to include both slide_id and complete content
containing the <slide>...</slide> XML, matching the schema described elsewhere.
Do not instruct users to create a slide_id-only file unless explicitly
documenting it as a separate dry-run-only schema.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8a754824-4ed6-42da-9861-b12e3ced3ab9
📒 Files selected for processing (3)
skills/lark-slides/SKILL.mdskills/lark-slides/references/lark-slides-edit-workflows.mdskills/lark-slides/references/lark-slides-replace-pages.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-slides/references/lark-slides-edit-workflows.md
…-page rollout completes Partially reverts the skill portion of #2143 (56fd29e). lark-cli now ships +update-slide, but the backend capability it depends on is still rolling out; on environments without it every call answers an invalid-param error. The skill was routing all whole-page and multi-page edits there, which turns a staged backend rollout into a hard failure for every agent that follows the guidance. Only the guidance moves: whole-page work routes to +replace-pages again, its reference page is restored (with the SML namespace examples migrated to https, a tree-wide change that landed while the page was deleted), and lark-slides-update-slide.md is removed so nothing steers a caller to a command the backend may refuse. The binary is untouched. +update-slide stays available for environments that already have the capability, and +replace-pages keeps working everywhere. Re-apply the skill routing by reverting this commit once the rollout completes.
818a556 to
2303c54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2187 +/- ##
=======================================
Coverage 75.72% 75.72%
=======================================
Files 944 944
Lines 100355 100355
=======================================
Hits 75994 75994
Misses 18565 18565
Partials 5796 5796 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What this changes
Partially reverts the skill portion of #2143: the lark-slides skill routes whole-page edits back to
+replace-pages, and the+update-slidereference page is temporarily removed from the skill.No binary change. Both shortcuts remain available; only the default skill guidance changes.
Why
The skill guidance is temporarily returning to the established compatibility path for whole-page edits.
Details
SKILL.md/lark-slides-edit-workflows.md: route single-page and multi-page whole-page edits to+replace-pages.references/lark-slides-replace-pages.md: restore the reference page while preserving subsequent documentation updates.references/lark-slides-update-slide.md: remove it from the skill temporarily.Follow-up
Restore the
+update-slideskill guidance when it is ready to become the default path.