Skip to content

docs(calendar): clarify attendee resolution to avoid type guessing - #2195

Merged
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-attendee-resolution
Aug 5, 2026
Merged

docs(calendar): clarify attendee resolution to avoid type guessing#2195
calendar-assistant merged 1 commit into
mainfrom
docs/calendar-attendee-resolution

Conversation

@calendar-assistant

@calendar-assistant calendar-assistant commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

When adding calendar attendees, an agent should resolve a name into an ID and, if that fails, ask the user to clarify the attendee type — not guess the type from the name shape. This reworks the note under the cross-domain search commands in the lark-calendar skill to make that explicit.

Changes

  • Reword the note under 常用其他域命令 in skills/lark-calendar/SKILL.md:
    • Broaden "search users doesn't support bot identity" to cover both user and chat search (必须用 --as user).
    • Replace the ou_ open_id usage sentence with an explicit rule: when a name cannot be resolved or its type is ambiguous, ask the user to clarify the attendee type instead of inferring it from the name shape.

Motivation

An evaluation case (cli_calendar_ext_001) failed because a meeting-room attendee — given only as a long, informal name — was searched as a user, then guessed to be a bot. The agent then triggered an unrelated search:bot device authorization and stalled on a QR-code prompt, so no event was ever created. The root cause was guessing the attendee type from the name shape; this doc change steers agents to clarify with the user instead.

Test Plan

  • Docs-only change to a skill markdown file; no code paths affected.
  • N/A — no unit/e2e tests apply to this skill content change.

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • Updated calendar participant search guidance to support both users and groups.
    • Clarified that ambiguous or unresolved participant types require confirmation rather than inference.

Reword the note under the cross-domain search commands so agents ask
the user to clarify an attendee's type when a name cannot be resolved
or is ambiguous, instead of guessing the type from the name shape
(e.g. treating an unmatched room name as a bot).

Co-authored-by: TRAE CLI <noreply@bytedance.com>
@github-actions github-actions Bot added domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d64dbe2-6dcd-4b99-b6e3-4b3f427063c3

📥 Commits

Reviewing files that changed from the base of the PR and between 0848a5b and ed8533f.

📒 Files selected for processing (1)
  • skills/lark-calendar/SKILL.md

📝 Walkthrough

Walkthrough

The calendar skill updates participant search guidance. Searches must use --as user for users and groups. Ambiguous or unresolved participant types require clarification instead of inference.

Changes

Calendar participant search

Layer / File(s) Summary
Participant search guidance
skills/lark-calendar/SKILL.md
The guidance covers users and groups, requires --as user, and requires clarification for ambiguous or unresolved participant types.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the documentation change that prevents incorrect attendee type inference.
Description check ✅ Passed The description includes the required summary, changes, test plan, and related issues sections with relevant details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/calendar-attendee-resolution

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@ed8533fb9431c337a110734f271afb66d48f2b18

🧩 Skill update

npx skills add larksuite/cli#docs/calendar-attendee-resolution -y -g

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.92%. Comparing base (0848a5b) to head (ed8533f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2195   +/-   ##
=======================================
  Coverage   75.92%   75.92%           
=======================================
  Files         962      962           
  Lines      102197   102197           
=======================================
  Hits        77591    77591           
  Misses      18716    18716           
  Partials     5890     5890           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calendar-assistant
calendar-assistant merged commit 875d20a into main Aug 5, 2026
32 of 42 checks passed
@calendar-assistant
calendar-assistant deleted the docs/calendar-attendee-resolution branch August 5, 2026 12:16
@liangshuo-1 liangshuo-1 mentioned this pull request Aug 5, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/calendar PR touches the calendar domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants