docs(skills): sync lark whiteboard skill - #2215
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (9)
📝 WalkthroughWalkthroughThe whiteboard guidance separates read and write routing, adds explicit editing paths and confirmation rules, clarifies export and overwrite behavior, updates workflow references, and documents ChangesWhiteboard workflow guidance
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: read ECONNRESET Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-whiteboard/references/lark-whiteboard-node-create.md`:
- Line 33: Pin the `@larksuite/whiteboard-cli` version exactly, replacing the
caret range in
skills/lark-whiteboard/references/lark-whiteboard-node-create.md:33 and applying
the same approved exact version or repository-pinned executable to all CLI
invocations in skills/lark-whiteboard/references/lark-whiteboard-update.md:76,
skills/lark-whiteboard/routes/dsl.md:28-33, and
skills/lark-whiteboard/routes/mermaid.md:16-19.
In `@skills/lark-whiteboard/references/lark-whiteboard-node-update.md`:
- Around line 34-36: The update documentation currently references the wrong
response wrapper paths. In the +node-update guidance, change the documented
envelope extraction path to data.result.nodes at the references on lines 36, 43,
and 88, while keeping raw input normalization as top-level nodes; ensure the
warning only discourages actively constructing an envelope and does not claim
data.nodes support.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6eb35fda-c9cf-4ddc-b2ec-b585ca62d350
📒 Files selected for processing (12)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/lark-whiteboard-export.mdskills/lark-whiteboard/references/lark-whiteboard-node-create.mdskills/lark-whiteboard/references/lark-whiteboard-node-delete.mdskills/lark-whiteboard/references/lark-whiteboard-node-update.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/lark-whiteboard-workflow.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg-edit.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/mention.md
Co-authored-by: TRAE CLI <traecli@bytedance.com>
6a3de6e to
de89640
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-whiteboard/SKILL.md`:
- Line 39: Separate the invalid combined --input_format values into individual
mermaid, plantuml, and svg alternatives in
skills/lark-whiteboard/SKILL.md:39-39, and individual mermaid and plantuml
alternatives in
skills/lark-whiteboard/references/lark-whiteboard-workflow.md:34-34; keep each
alternative as a separate command value.
- Line 39: Update the Mermaid/PlantUML/SVG routing table in SKILL.md to
distinguish new SVG creation from edits to an existing board. For existing-board
SVG edits, require the confirmation workflow defined in routes/svg-edit.md
before invoking +update; keep the direct +update path for user-supplied
Mermaid/PlantUML code and new SVG creation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a6dfc65b-595e-4a0e-8e8d-587cfb7eb464
📒 Files selected for processing (9)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/lark-whiteboard-export.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/lark-whiteboard-workflow.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg-edit.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/mention.md
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/lark-whiteboard/routes/svg.md
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@a446f1b08534ff2bd310ce3fbe1d23e006280768🧩 Skill updatenpx skills add ZKHelloworld/lark-cli#sync-lark-whiteboard-20260806 -y -g |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
skills/lark-whiteboard/references/lark-whiteboard-workflow.md (1)
50-60: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winMake the current artifact type an explicit routing condition.
Line 50 claims that routing uses the current artifact type, chart type, and identity. Lines 54-60 define only chart type and identity, with a separate mention/image rule. They do not define how an existing Mermaid, PlantUML, SVG, or DSL artifact affects routing. This can select a renderer that conflicts with the final write format in Lines 85-90. Add an artifact-type column or define its precedence over chart type and identity.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-whiteboard/references/lark-whiteboard-workflow.md` around lines 50 - 60, Update the routing table and matching rules around the current artifact routing section to explicitly include the current artifact type (such as Mermaid, PlantUML, SVG, or DSL) as a routing condition. Define its precedence relative to the existing mention/image, chart-type, and identity rules, ensuring the selected route remains compatible with the final write format described later in the workflow.
🧹 Nitpick comments (1)
skills/lark-whiteboard/references/lark-whiteboard-workflow.md (1)
34-35: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winDocument
source’s Mermaid/PlantUML selection rule.
+export --output-type sourcedocuments returning source code, but the workflow routes this output to two different+update --input_formatvalues. Add the source-type marker or detection rule so agents send valid source to the matching parser.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-whiteboard/references/lark-whiteboard-workflow.md` around lines 34 - 35, 在工作流中补充 Mermaid 与 PlantUML 源码的识别规则或 source 类型标记,明确 `+export --output-type source` 的返回类型如何确定;确保代理依据该规则将源码分别传给匹配的 `+update --input_format mermaid` 或 `plantuml`,避免解析器选择错误。
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-whiteboard/references/lark-whiteboard-workflow.md`:
- Around line 34-35: The source-backed Mermaid and PlantUML rows in the workflow
documentation must explicitly handle user-requested append operations. Update
the Mermaid/PlantUML edit guidance to either allow the documented user-specified
append exception, matching the SVG guidance, or require confirmation that append
re-renders the complete source instead of unconditionally using overwrite.
---
Outside diff comments:
In `@skills/lark-whiteboard/references/lark-whiteboard-workflow.md`:
- Around line 50-60: Update the routing table and matching rules around the
current artifact routing section to explicitly include the current artifact type
(such as Mermaid, PlantUML, SVG, or DSL) as a routing condition. Define its
precedence relative to the existing mention/image, chart-type, and identity
rules, ensuring the selected route remains compatible with the final write
format described later in the workflow.
---
Nitpick comments:
In `@skills/lark-whiteboard/references/lark-whiteboard-workflow.md`:
- Around line 34-35: 在工作流中补充 Mermaid 与 PlantUML 源码的识别规则或 source 类型标记,明确 `+export
--output-type source` 的返回类型如何确定;确保代理依据该规则将源码分别传给匹配的 `+update --input_format
mermaid` 或 `plantuml`,避免解析器选择错误。
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f1155a8b-0f47-4db7-a918-20555bf18d7b
📒 Files selected for processing (2)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/lark-whiteboard-workflow.md
7bfad69 to
3cc6a2c
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/lark-whiteboard/SKILL.md`:
- Line 39: Use one confirmation gate for all existing-board source edits: update
skills/lark-whiteboard/SKILL.md lines 39-39 to route existing-board
Mermaid/PlantUML changes through the edit workflow before +update, and update
skills/lark-whiteboard/references/lark-whiteboard-workflow.md lines 86-86 to
apply the same confirmation rule to existing-board Mermaid/PlantUML writes or
restrict direct writes to new boards.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ebcff70b-4c9f-4f66-8659-0caee427dfe3
📒 Files selected for processing (9)
skills/lark-whiteboard/SKILL.mdskills/lark-whiteboard/references/lark-whiteboard-export.mdskills/lark-whiteboard/references/lark-whiteboard-update.mdskills/lark-whiteboard/references/lark-whiteboard-workflow.mdskills/lark-whiteboard/routes/dsl.mdskills/lark-whiteboard/routes/mermaid.mdskills/lark-whiteboard/routes/svg-edit.mdskills/lark-whiteboard/routes/svg.mdskills/lark-whiteboard/scenes/mention.md
🚧 Files skipped from review as they are similar to previous changes (4)
- skills/lark-whiteboard/references/lark-whiteboard-export.md
- skills/lark-whiteboard/routes/dsl.md
- skills/lark-whiteboard/routes/mermaid.md
- skills/lark-whiteboard/routes/svg.md
Co-authored-by: TRAE CLI <traecli@bytedance.com>
3cc6a2c to
a446f1b
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
--input_formatexamples into concrete command valuessvg-editconfirmation workflowVerification
Summary by CodeRabbit
新功能
文档