Skip to content

fix: align slides xml-get skill flags - #2237

Merged
BD-ZERO merged 3 commits into
mainfrom
fix/slides-xml-get-skill-flags
Aug 7, 2026
Merged

fix: align slides xml-get skill flags#2237
BD-ZERO merged 3 commits into
mainfrom
fix/slides-xml-get-skill-flags

Conversation

@BD-ZERO

@BD-ZERO BD-ZERO commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Align the lark-slides Skill documentation with the public slides +xml-get flags so agents do not combine incompatible output options such as --raw and --output.

Changes

  • Document --raw, --slide-id, and --slide-number, including their incompatibility rules.
  • Add examples for saving single-slide XML and streaming raw XML.
  • Add a regression test requiring every public shortcut-specific flag to appear in the Skill reference.

Test Plan

  • go test ./shortcuts/slides
  • make build
  • Skill format and token checks pass for lark-slides
  • 16 independent subagent trials across 8 usage scenarios produced valid commands with no incompatible flag combinations

Related Issues

  • None

Summary by CodeRabbit

  • Documentation
    • 扩展幻灯片 XML 获取命令的参数说明,新增原始 XML 输出、单页读取及移除 XML 属性 ID 的选项。
    • 补充单页保存与管道输出示例,帮助用户更灵活地处理演示文稿内容。
    • 清理快捷命令示例中的无效空行。

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d816e9cb-12fc-4a0b-8c5d-c14887263c5b

📥 Commits

Reviewing files that changed from the base of the PR and between 819c0ea and caa1ebd.

📒 Files selected for processing (1)
  • skills/lark-slides/references/lark-slides-xml-presentations-get.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-slides/references/lark-slides-xml-presentations-get.md

📝 Walkthrough

Walkthrough

更新 slides +xml-get 参考文档,补充原始 XML、单页读取、属性 ID 移除参数及保存和管道输出示例。

Changes

Slides XML Get 文档

Layer / File(s) Summary
更新 XML Get 参数和使用示例
skills/lark-slides/references/lark-slides-xml-presentations-get.md
说明完整演示文稿和单页 XML 读取方式,新增 --raw--slide-id--slide-number 参数约束,并补充单页保存及管道输出示例。

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: bugfix

Suggested reviewers: ethan-zhx

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the alignment of the slides XML-get skill flags, which is the main change.
Description check ✅ Passed The description includes all required sections and clearly documents the changes, tests, and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/slides-xml-get-skill-flags

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Aug 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-slides/references/lark-slides-xml-presentations-get.md`:
- Around line 25-28: The purpose statement for the XML presentation read
shortcut must cover both complete-presentation XML and single-slide XML returned
when --slide-id or --slide-number is set. Update that statement while preserving
the existing descriptions of the command’s behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 64395d7d-73fb-4acf-866d-2c3f64fee1d2

📥 Commits

Reviewing files that changed from the base of the PR and between bc0ba22 and 819c0ea.

📒 Files selected for processing (2)
  • shortcuts/slides/slides_xml_get_test.go
  • skills/lark-slides/references/lark-slides-xml-presentations-get.md

Comment thread skills/lark-slides/references/lark-slides-xml-presentations-get.md
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@caa1ebd648215e484d2d7a90a8b6685bf16b6eeb

🧩 Skill update

npx skills add larksuite/cli#fix/slides-xml-get-skill-flags -y -g

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.33%. Comparing base (be2a96f) to head (caa1ebd).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   76.34%   76.33%   -0.01%     
==========================================
  Files         991      993       +2     
  Lines      106019   106633     +614     
==========================================
+ Hits        80940    81400     +460     
- Misses      18944    19032      +88     
- Partials     6135     6201      +66     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread skills/lark-slides/references/lark-slides-xml-presentations-get.md
@BD-ZERO
BD-ZERO merged commit 771ff44 into main Aug 7, 2026
32 of 46 checks passed
@BD-ZERO
BD-ZERO deleted the fix/slides-xml-get-skill-flags branch August 7, 2026 09:24
@liangshuo-1 liangshuo-1 mentioned this pull request Aug 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants