fix: make download preflight invalid-token failures actionable - #2287
fix: make download preflight invalid-token failures actionable#2287ViperCai wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2287 +/- ##
=======================================
Coverage 76.45% 76.45%
=======================================
Files 1013 1013
Lines 112034 112045 +11
=======================================
+ Hits 85658 85668 +10
- Misses 19864 19865 +1
Partials 6512 6512 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Keep the existing export-permission preflight for both document media and Drive file downloads. When the preflight returns
1063001 Invalid parameter, classify the input as non-retryable and tell agents how to recover from a stale or wrong token instead of repeatedly retrying it.Changes
docs +media-downloadpreflight withtype=file,action=export; a real current document image token was verified to pass this check and download successfully.drive +downloadpreflight for uploaded Drive files.1063001as non-retryable and add command-specific token recovery guidance without exposing caller tokens.Test Plan
make unit-testgo vet ./...gofmt -l .produces no outputgo mod tidyproduces no module changesauth_result=true) anddocs +media-downloadsaved 497,808 bytesRelated Issues