feat(lark-im): support UAT for forward and add threads.forward#689
Merged
YangJunzhou-01 merged 1 commit intoMay 11, 2026
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDocs and CLI E2E tests now document and exercise IM message and thread forwarding as both ChangesIM docs and CLI E2E
Endpoint / CLI defaults
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
domain/im
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
tests/cli_e2e/im/coverage.md (1)
13-16: Minor readability nit: vary repeated “proves …” sentence starts.The summary bullets read a bit repetitive; a small rephrase would improve scanability.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/cli_e2e/im/coverage.md` around lines 13 - 16, The three bullet lines repeating "proves" should be reworded for readability: update TestIM_MessageGetWorkflowAsUser to start with "Validates user message readback..." (reference: `TestIM_MessageGetWorkflowAsUser` and "batch get message as user"), change TestIM_MessageReplyWorkflowAsBot to "Exercises threaded reply flow..." (reference: `TestIM_MessageReplyWorkflowAsBot`, `reply to message in thread as bot`, `im +threads-messages-list`), and change TestIM_MessageForwardWorkflowAsUser to "Demonstrates UAT-backed API forwarding..." (reference: `TestIM_MessageForwardWorkflowAsUser`, `im messages forward`, `im threads forward`); leave the blocked area sentence as-is.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-im/SKILL.md`:
- Around line 108-110: The permission table is missing a row for threads.forward
and its scope mapping is inconsistent with the API doc: add a permission entry
for "threads.forward" in the table and include the exact scope(s) used (e.g.,
im:message.send_as_user) in the same row's scopes column or notes; if mappings
differ by identity (user vs bot), state those differences in the row notes (for
example: "user: im:message.send_as_user; bot: im:message.send") so the table
aligns with the API doc and the PR's forward mapping.
In `@tests/cli_e2e/im/message_forward_workflow_test.go`:
- Around line 17-94: TestIM_MessageForwardWorkflowAsUser leaves created messages
behind; capture the created IDs (the initial messageID from
sendDirectMessageToUser, the threadID from findThreadIDForMessage, and the
forwardedIDs parsed from result.Stdout in both forward steps) and register
cleanup via t.Cleanup to delete them after the test completes. Specifically,
after obtaining messageID, threadID and each forwardedID (variables messageID,
threadID, forwardedID), call the same CLI/API delete operations used elsewhere
(e.g., the "im messages delete" / thread delete endpoint via clie2e.RunCmd)
inside t.Cleanup so removal always runs even on failures; ensure you handle
empty IDs and ignore not-found errors.
- Around line 21-29: This test performs bot-based setup (calls
sendDirectMessageToUser(..., "bot") and later uses the im messages-reply flow)
but only calls clie2e.SkipWithoutUserToken(t); update the test to guard
bot-specific steps by calling clie2e.SkipWithoutBotToken(t) (or a combined
bot-or-user skip helper) before invoking sendDirectMessageToUser and before the
im +messages-reply section so the test will be skipped cleanly in user-only
environments; apply the same change to the second bot-setup block referenced
(the section around sendDirectMessageToUser/im +messages-reply at lines 55-63).
---
Nitpick comments:
In `@tests/cli_e2e/im/coverage.md`:
- Around line 13-16: The three bullet lines repeating "proves" should be
reworded for readability: update TestIM_MessageGetWorkflowAsUser to start with
"Validates user message readback..." (reference:
`TestIM_MessageGetWorkflowAsUser` and "batch get message as user"), change
TestIM_MessageReplyWorkflowAsBot to "Exercises threaded reply flow..."
(reference: `TestIM_MessageReplyWorkflowAsBot`, `reply to message in thread as
bot`, `im +threads-messages-list`), and change
TestIM_MessageForwardWorkflowAsUser to "Demonstrates UAT-backed API
forwarding..." (reference: `TestIM_MessageForwardWorkflowAsUser`, `im messages
forward`, `im threads forward`); leave the blocked area sentence as-is.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 659263d7-3593-45fc-b1ee-6b64823fdc68
📒 Files selected for processing (3)
skills/lark-im/SKILL.mdtests/cli_e2e/im/coverage.mdtests/cli_e2e/im/message_forward_workflow_test.go
chenxingtong-bytedance
force-pushed
the
feat/support_uat_forward_msg
branch
from
April 28, 2026 12:01
43005e5 to
9904add
Compare
github-actions
Bot
added
size/L
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cmd/root.go (1)
312-317:⚠️ Potential issue | 🟠 MajorAdd tests for the brand-based host selection in
enrichPermissionError.The code at lines 312–316 switches the permission-console host based on brand (
open.feishu-pre.cnfor non-lark,open.larksuite.comfor lark), changing user-facing guidance in error output. Current tests incmd/root_test.govalidate URL escaping but do not explicitly test this host selection logic. Per the coding guideline: Every behavior change must have an accompanying test.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/root.go` around lines 312 - 317, Add unit tests for enrichPermissionError that assert the permission-console host selection based on cfg.Brand: create two test cases (cfg.Brand == "lark" and a non-lark brand) and verify the returned error message or consoleURL contains "open.larksuite.com" for lark and "open.feishu-pre.cn" for non-lark, and still preserves URL-escaped AppID/scopes; locate enrichPermissionError usage and the host/consoleURL construction in cmd/root.go and add assertions in cmd/root_test.go that call enrichPermissionError (or the public wrapper that emits the message) and check the resulting string includes the expected host and escaped parameters.
♻️ Duplicate comments (3)
tests/cli_e2e/im/message_forward_workflow_test.go (2)
21-29:⚠️ Potential issue | 🟠 MajorGuard bot-based fixture steps with a bot-token precheck.
The workflow uses bot identity in setup (
sendDirectMessageToUser(..., "bot")and+messages-reply) but only checks for user token. Addclie2e.SkipWithoutBotToken(t)before bot-backed steps so environments without bot token skip cleanly.Also applies to: 55-63
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/cli_e2e/im/message_forward_workflow_test.go` around lines 21 - 29, The test uses bot-backed setup steps but only calls clie2e.SkipWithoutUserToken(t); add a bot-token precheck by calling clie2e.SkipWithoutBotToken(t) immediately before any bot-identity operations (e.g., before sendDirectMessageToUser(t, ctx, selfOpenID, messageText, "bot") and before the block that posts message replies via messages-reply); update both occurrences (the initial setup and the later reply-related block) so environments without a bot token are skipped cleanly.
17-94:⚠️ Potential issue | 🟠 MajorAdd cleanup for created IM artifacts to keep the live E2E self-contained.
This flow creates source/reply/forwarded messages but does not register cleanup. Please collect created IDs and delete them in
t.Cleanup(best-effort, ignore not-found).As per coding guidelines:
Live E2E tests must be self-contained with create/use/cleanup flows and placed in tests/cli_e2e/<domain>/.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/cli_e2e/im/message_forward_workflow_test.go` around lines 17 - 94, The test TestIM_MessageForwardWorkflowAsUser creates messages and a thread (messageID, forwardedID, threadID) but never deletes them; add a t.Cleanup block that best-effort deletes the created artifacts after the test (ignore not-found errors). Capture IDs returned from sendDirectMessageToUser, the first forward result (data.message_id), and the thread-forward result (data.message_id) and call the same CLI helper used elsewhere (clie2e.RunCmd) or existing helper functions to delete messages/threads (use the same params/DefaultAs that created them) in the cleanup; also remove any duplicate resources if both original and forwarded IDs exist. Ensure cleanup references the symbols messageID, forwardedID, threadID, sendDirectMessageToUser, findThreadIDForMessage, and clie2e.RunCmd so reviewers can find where to add the deletion calls.skills/lark-im/SKILL.md (1)
97-110:⚠️ Potential issue | 🟠 MajorForward permission table is still incomplete/inconsistent.
messages.forwardandthreads.forwardare documented asuser+bot, but the scope table only hasmessages.forward | im:messageand nothreads.forwardrow. Please add both forward rows with identity-specific scopes (includingim:message.send_as_userfor user path).Suggested table shape
| `messages.forward` | `im:message` | +| `messages.forward` | `bot: im:message; user: im:message.send_as_user` | +| `threads.forward` | `bot: im:message; user: im:message.send_as_user` |Also applies to: 124-147
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@skills/lark-im/SKILL.md` around lines 97 - 110, Add missing scope table rows for messages.forward and threads.forward and make them identity-specific: for messages.forward include both im:message (bot) and im:message.send_as_user (user); for threads.forward include both im:thread (bot) and im:thread.send_as_user (user). Update the permissions table entries that reference messages.forward and threads.forward so they list the appropriate scopes per identity and ensure the narrative above (the bullets under messages and threads) matches these new table rows.
🧹 Nitpick comments (1)
cmd/root.go (1)
312-315: Avoid duplicating brand→host mapping here.This mapping now exists in both
cmd/root.goandinternal/core/types.go; deriving fromcore.ResolveOpenBaseURL(core.ParseBrand(cfg.Brand))would reduce drift risk.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/root.go` around lines 312 - 315, The host selection in root.go duplicates brand→host mapping; replace the inline branch that sets host based on cfg.Brand with a call to the centralized resolver: use core.ResolveOpenBaseURL(core.ParseBrand(cfg.Brand)) to derive the host (or base URL) instead of hardcoding "open.feishu-pre.cn"/"open.larksuite.com"; update references to the local host variable to use the returned value and remove the duplicated mapping logic to avoid drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@internal/core/types.go`:
- Around line 43-45: Update the test TestResolveEndpoints_EmptyDefaultsToFeishu
in internal/core/types_test.go to expect the new default domain "feishu-pre.cn"
instead of "feishu.cn"; specifically change assertions that compare resolved
endpoints (Open, Accounts, MCP) to expect "https://open.feishu-pre.cn",
"https://accounts.feishu-pre.cn", and "https://mcp.feishu-pre.cn" so they match
the defaults defined for Open, Accounts, and MCP in the types (the resolved
endpoints used by ResolveEndpoints/ResolveBrandDefaults logic).
---
Outside diff comments:
In `@cmd/root.go`:
- Around line 312-317: Add unit tests for enrichPermissionError that assert the
permission-console host selection based on cfg.Brand: create two test cases
(cfg.Brand == "lark" and a non-lark brand) and verify the returned error message
or consoleURL contains "open.larksuite.com" for lark and "open.feishu-pre.cn"
for non-lark, and still preserves URL-escaped AppID/scopes; locate
enrichPermissionError usage and the host/consoleURL construction in cmd/root.go
and add assertions in cmd/root_test.go that call enrichPermissionError (or the
public wrapper that emits the message) and check the resulting string includes
the expected host and escaped parameters.
---
Duplicate comments:
In `@skills/lark-im/SKILL.md`:
- Around line 97-110: Add missing scope table rows for messages.forward and
threads.forward and make them identity-specific: for messages.forward include
both im:message (bot) and im:message.send_as_user (user); for threads.forward
include both im:thread (bot) and im:thread.send_as_user (user). Update the
permissions table entries that reference messages.forward and threads.forward so
they list the appropriate scopes per identity and ensure the narrative above
(the bullets under messages and threads) matches these new table rows.
In `@tests/cli_e2e/im/message_forward_workflow_test.go`:
- Around line 21-29: The test uses bot-backed setup steps but only calls
clie2e.SkipWithoutUserToken(t); add a bot-token precheck by calling
clie2e.SkipWithoutBotToken(t) immediately before any bot-identity operations
(e.g., before sendDirectMessageToUser(t, ctx, selfOpenID, messageText, "bot")
and before the block that posts message replies via messages-reply); update both
occurrences (the initial setup and the later reply-related block) so
environments without a bot token are skipped cleanly.
- Around line 17-94: The test TestIM_MessageForwardWorkflowAsUser creates
messages and a thread (messageID, forwardedID, threadID) but never deletes them;
add a t.Cleanup block that best-effort deletes the created artifacts after the
test (ignore not-found errors). Capture IDs returned from
sendDirectMessageToUser, the first forward result (data.message_id), and the
thread-forward result (data.message_id) and call the same CLI helper used
elsewhere (clie2e.RunCmd) or existing helper functions to delete
messages/threads (use the same params/DefaultAs that created them) in the
cleanup; also remove any duplicate resources if both original and forwarded IDs
exist. Ensure cleanup references the symbols messageID, forwardedID, threadID,
sendDirectMessageToUser, findThreadIDForMessage, and clie2e.RunCmd so reviewers
can find where to add the deletion calls.
---
Nitpick comments:
In `@cmd/root.go`:
- Around line 312-315: The host selection in root.go duplicates brand→host
mapping; replace the inline branch that sets host based on cfg.Brand with a call
to the centralized resolver: use
core.ResolveOpenBaseURL(core.ParseBrand(cfg.Brand)) to derive the host (or base
URL) instead of hardcoding "open.feishu-pre.cn"/"open.larksuite.com"; update
references to the local host variable to use the returned value and remove the
duplicated mapping logic to avoid drift.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0563c2c1-8af9-4b11-8815-d01634a5be2a
📒 Files selected for processing (5)
cmd/root.gointernal/core/types.goskills/lark-im/SKILL.mdtests/cli_e2e/im/coverage.mdtests/cli_e2e/im/message_forward_workflow_test.go
chenxingtong-bytedance
force-pushed
the
feat/support_uat_forward_msg
branch
3 times, most recently
from
May 11, 2026 04:46
5320306 to
9d3ff8c
Compare
- Update messages.forward identity to support `user` and `bot` - Add threads.forward entry under threads API resources - Add forward APIs -> `im:message`, `im:message.send_as_user` scope mapping Change-Id: I2e33b0d78d72fd067ba3916095479f9b336e7eb9
chenxingtong-bytedance
force-pushed
the
feat/support_uat_forward_msg
branch
from
May 11, 2026 04:55
9d3ff8c to
76ebae9
Compare
github-actions
Bot
added
size/M
jackie3927
approved these changes
May 11, 2026
YangJunzhou-01
approved these changes
May 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 65.60% 65.60%
=======================================
Files 513 513
Lines 47644 47644
=======================================
Hits 31259 31259
Misses 13685 13685
Partials 2700 2700 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@76ebae9fa4a6a60e1e9ea0fe2d8f6540577c266b🧩 Skill updatenpx skills add chenxingtong-bytedance/cli#feat/support_uat_forward_msg -y -g |
tuxedomm
pushed a commit
to zhumiaoxin/cli
that referenced
this pull request
Jun 6, 2026
…suite#689) - Update messages.forward identity to support `user` and `bot` - Add threads.forward entry under threads API resources - Add forward APIs -> `im:message`, `im:message.send_as_user` scope mapping Change-Id: I2e33b0d78d72fd067ba3916095479f9b336e7eb9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support IM forward APIs in UAT/user identity scenarios by updating
messages.forwardidentity metadata and addingthreads.forwardAPI resourcedocumentation. Also add E2E coverage for message and thread forwarding workflows.
Changes
lark-imskill docs somessages.forwardsupports bothuserandbotidentities.threads.forwardto IM API resources.im:message/im:message.send_as_user.TestIM_MessageForwardWorkflowAsUserE2E coverage forim messages forwardandim threads forward.Test Plan
make unit-testgo test ./tests/cli_e2e/im -run TestIM_MessageForwardWorkflowAsUser -count=1lark im messages forward --as userlark im threads forward --as userRelated Issues
N/A
Summary by CodeRabbit
Documentation
Tests
Chores