docs(base): update location full_address guidance#754
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates skill and reference documentation to standardize location field behavior across the Lark Base platform. Changes clarify that location writes use minimal ChangesLocation field specification and reference docs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 67.77% 67.76% -0.02%
==========================================
Files 590 590
Lines 55194 55194
==========================================
- Hits 37406 37400 -6
- Misses 14677 14682 +5
- Partials 3111 3112 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@1bdb4754d46a6a5e6e37f15fdec443009fc728ac🧩 Skill updatenpx skills add zgz2048/cli#codex/base-location-full-address-skill -y -g |
9ff0d21 to
6007d6a
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skill-template/domains/base.md`:
- Line 37: Update the wording under the "**地理位置字段**" section to make `{lng,lat}`
mandatory (not optional); replace language like "推荐写入 `{lng,lat}`" with a clear
requirement such as "必须写入 `{lng,lat}` 且只接受 `{lng,lat}` 格式" and keep the rest
(use `full_address` for read/filter/convert and use contains-match for
filtering) intact so readers know reads/filters still prefer `full_address`
while writes must supply `{lng,lat}`.
In `@skills/lark-base/SKILL.md`:
- Line 219: Change the table row for 地理位置字段 to state that writes accept only the
{lng,lat} format (replace wording like "推荐写入形状是 `{lng,lat}`" with a mandatory
phrase such as "仅接受写入格式 `{lng,lat}`;`full_address` 不能直接写入") and add a brief note
in the explanation column that filtering should prioritize contains-matching
(match the "筛选优先用包含匹配" guidance from base.md) so readers know both the required
write format and the expected filter strategy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fc769087-d38a-4e8b-8a71-30e848f259a7
📒 Files selected for processing (7)
skill-template/domains/base.mdskills/lark-base/SKILL.mdskills/lark-base/references/lark-base-cell-value.mdskills/lark-base/references/lark-base-data-query.mdskills/lark-base/references/lark-base-field-update.mdskills/lark-base/references/lark-base-shortcut-field-properties.mdskills/lark-base/references/lark-base-view-set-filter.md
✅ Files skipped from review due to trivial changes (5)
- skills/lark-base/references/lark-base-data-query.md
- skills/lark-base/references/lark-base-shortcut-field-properties.md
- skills/lark-base/references/lark-base-view-set-filter.md
- skills/lark-base/references/lark-base-field-update.md
- skills/lark-base/references/lark-base-cell-value.md
6007d6a to
1bdb475
Compare
Summary
Update Base skill guidance for location field full_address behavior, covering read/write, filtering, and type conversion semantics.
Changes
{lng,lat}andfull_addressis returned after platform resolution.full_addresstext and should prefer contains/intersects over short exact matches.location -> textconversion keepsfull_address, and sync the Base domain template.Test Plan
node scripts/skill-format-check/index.js skillsmake unit-testlark-cli base --helpRelated Issues
Summary by CodeRabbit
{lng,lat}), read-side preferences (full_address), and filtering best practices using address text matching.