fix: mark base field update high risk#936
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughBaseFieldUpdate shortcut is reclassified as high-risk-write with risk metadata updated, a corresponding unit test added to verify the risk classification, and the execution test modified to pass the --yes confirmation flag. ChangesBaseFieldUpdate Risk Reclassification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8c72690 to
8c648f9
Compare
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@3ea89ec0d541583481378a72cfa86df7f326355b🧩 Skill updatenpx skills add zgz2048/cli#codex/base-risk-tags -y -g |
8c648f9 to
3ea89ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 65.92% 65.92%
=======================================
Files 523 523
Lines 49692 49694 +2
=======================================
+ Hits 32758 32760 +2
Misses 14134 14134
Partials 2800 2800 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM. Verified locally with:
go test ./shortcuts/basego test ./shortcuts/common ./shortcuts/base
Non-blocking: shortcuts/base/field_update.go tips still show +field-update examples without --yes, while the command is now high-risk-write. Consider updating those examples so copied help output succeeds.
Summary
base +field-updateashigh-risk-write.--yesunder the high-risk confirmation gate.--yesfor field updates.Why
field updateis implemented with PUT semantics and sends a complete field definition, not a narrow patch. Changing a Base field can change the column type or configuration, which may affect how the entire column of existing data is interpreted, displayed, or remains usable. It should require explicit confirmation like other high-risk Base schema changes.The skill docs need to match this behavior; otherwise agents may keep generating
+field-updatecommands without--yesand hit the confirmation gate.Validation
go test ./shortcuts/baseSummary by CodeRabbit
Bug Fixes
Documentation
Tests