Skip to content

docs(drive): clarify add comment constraints#967

Merged
SunPeiYang996 merged 1 commit into
mainfrom
sun/chore
May 19, 2026
Merged

docs(drive): clarify add comment constraints#967
SunPeiYang996 merged 1 commit into
mainfrom
sun/chore

Conversation

@SunPeiYang996

@SunPeiYang996 SunPeiYang996 commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Change-Id: I637cfaf2d6a228c43e3b3041fef8e030bc80b9d0

Summary

docs(drive): clarify add comment constraints

Summary by CodeRabbit

  • Documentation
    • Clarified Slide comment limitations when using block identifiers: both full-comment and selection-with-ellipsis are not available for slides.
    • Removed prior details about local-comment locate behavior (previous fixed-limit and multi-match narrowing instructions).

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e93d9395-2557-41df-a73f-ea20d8f01c84

📥 Commits

Reviewing files that changed from the base of the PR and between 87fb9b8 and bc9e775.

📒 Files selected for processing (1)
  • skills/lark-drive/references/lark-drive-add-comment.md
💤 Files with no reviewable changes (1)
  • skills/lark-drive/references/lark-drive-add-comment.md

📝 Walkthrough

Walkthrough

The lark-drive add-comment reference clarifies that when --doc is slides and --block-id is used, --full-comment and --selection-with-ellipsis are unavailable, and removes prior locate-doc implementation details (fixed limit=10 and multi-match selection guidance).

Changes

Documentation Reference Updates

Layer / File(s) Summary
Slide Comment Constraints and Locate-Doc Details
skills/lark-drive/references/lark-drive-add-comment.md
Emphasizes that for slides with --block-id, --full-comment and --selection-with-ellipsis cannot be used (line 143). Removes locate-doc implementation details (limit=10 and multi-match --selection-with-ellipsis guidance) (lines 152-153).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • larksuite/cli#674: Main PR updates the lark-drive-add-comment documentation to reflect slides-specific CLI constraints disabling --full-comment and --selection-with-ellipsis when slides + --block-id are used.

Suggested labels

domain/ccm

Suggested reviewers

  • fangshuyu-768

Poem

A rabbit nibbles plain and neat,
Lines trimmed down to make docs sweet,
Slides now say what they must do,
Full comments paused, old notes adieu,
Hopping off with a carrot-cheer 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and largely off-topic. It is missing required sections (Changes, Test Plan) and contains only the Change-Id and title without meaningful content. Complete the description by adding a Summary section explaining the motivation, a Changes section listing the specific documentation updates, and a Test Plan section describing verification steps.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: documentation updates that clarify constraints for adding comments in the Lark Drive feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sun/chore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 19, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.39%. Comparing base (e6bc292) to head (bc9e775).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files         572      572           
  Lines       53655    53659    +4     
=======================================
+ Hits        36161    36165    +4     
  Misses      14486    14486           
  Partials     3008     3008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@bc9e7755adb70b8c3f5bf910c2b56f0044d6ff66

🧩 Skill update

npx skills add larksuite/cli#sun/chore -y -g

Change-Id: I637cfaf2d6a228c43e3b3041fef8e030bc80b9d0
@SunPeiYang996
SunPeiYang996 merged commit a4c5ec9 into main May 19, 2026
22 checks passed
@SunPeiYang996
SunPeiYang996 deleted the sun/chore branch May 19, 2026 10:09
@liangshuo-1 liangshuo-1 mentioned this pull request May 19, 2026
2 tasks
tuxedomm pushed a commit to zhumiaoxin/cli that referenced this pull request Jun 6, 2026
Change-Id: I637cfaf2d6a228c43e3b3041fef8e030bc80b9d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants