fix(auth): return validation error when --scope is empty in auth check

[mengqiuzhen]

Summary

auth check --scope "" returned ok: true instead of a validation error. strings.Fields("") produces an empty slice, which matches len(required) == 0, causing the command to report success without checking any scopes.

Fix

Replace the false-positive success path with output.ErrValidation("--scope cannot be empty"), consistent with error handling patterns elsewhere in the auth package.

Changes

• cmd/auth/check.go: 1 insertion, 2 deletions

Verification

• go build ./... — clean
• go test ./cmd/auth/... — all pass (1 pre-existing Windows file-cleanup failure unrelated)

Closes #116

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed auth check --scope validation to properly reject empty scope values with an error instead of returning a success response.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6bd77c41-182f-4a1f-8d38-f77713dd3a3a

📥 Commits

Reviewing files that changed from the base of the PR and between 3bab9a0 and 96be0f8.

📒 Files selected for processing (1)

• cmd/auth/check.go

---

📝 Walkthrough

Walkthrough

The PR fixes auth check --scope validation: when the scope flag parses to an empty set, the command now returns a validation error instead of reporting success with empty grant/missing lists.

Changes

Empty Scope Validation

Layer / File(s)	Summary
Scope empty validation error cmd/auth/check.go	When the parsed --scope is empty, the command now fails with a validation error rather than treating it as a successful check that grants nothing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

size/L

Suggested reviewers

• JackZhao10086
• albertnusouo

Poem

A rabbit found scopes empty as night,
No grant, no miss—just wrong, not right!
Now validation catches this plight,
Returns an error, shining bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing a validation error return for empty --scope in the auth check command.
Description check	✅ Passed	The description covers the summary, fix, changes, and verification sections matching the template, though it lacks explicit test plan checkboxes.
Linked Issues check	✅ Passed	The PR directly addresses issue #116 by replacing the false-positive success path with a validation error when --scope is empty, exactly as specified in the issue.
Out of Scope Changes check	✅ Passed	All changes are limited to cmd/auth/check.go and directly address the validation issue in #116; no unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.67%. Comparing base (6840bb7) to head (96be0f8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/auth/check.go	0.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   67.66%   67.67%           
=======================================
  Files         576      576           
  Lines       54510    54509    -1     
=======================================
+ Hits        36885    36887    +2     
+ Misses      14566    14564    -2     
+ Partials     3059     3058    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@96be0f86e4bd5f6131db6583750a9f49f1e3a1fa

🧩 Skill update

npx skills add mengqiuzhen/Feishu-cli#fix/116-auth-check-empty-scope -y -g