Adding optional headers parameter to Http client request#386
Closed
blackgerman wants to merge 1 commit intolarryaasen:masterfrom
Closed
Adding optional headers parameter to Http client request#386blackgerman wants to merge 1 commit intolarryaasen:masterfrom
blackgerman wants to merge 1 commit intolarryaasen:masterfrom
Conversation
blackgerman
force-pushed
the
adding_header_to_http_client_appcast
branch
from
adbfea2 to
8c97caa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 10 10
Lines 1091 1092 +1
=======================================
+ Hits 1002 1003 +1
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Owner
|
@blackgerman Thanks for your PR and your suggestion about client headers, which I think is a useful idea. I decided to go a slightly different route with the implementation, so I will close this PR and make the updates myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context 🤔
App cast an http request to fetch version update file on a remote server. Issue is, when the file is protected (example: file is on a private remote repository), app cannot access the files without headers.
What did we do ? 🏮
Added optional header parameters to
AppcastConfigurationobject so that we can easily pass set of headers if we need to.What to test ? 🧪
Test that the added parameter is really optional and doesn't break the basic flow.