Remove foundation team code owner review requirement - #152
Merged
Conversation
Delete .github/CODEOWNERS which assigned @launchdarkly/team-foundation as a required code owner for all files, forcing their review before merge. Co-authored-by: Ramon Niebla <nieblara@users.noreply.github.com>
nieblara
marked this pull request as ready for review
August 10, 2026 22:49
nieblara
enabled auto-merge (squash)
August 10, 2026 22:49
erangeles
approved these changes
Aug 10, 2026
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the requirement for the foundation team (
@launchdarkly/team-foundation) to review every PR before merge.The
.github/CODEOWNERSfile contained a single catch-all rule:Combined with the branch protection setting "Require review from Code Owners", this made the foundation team a required reviewer on every pull request. Deleting the file removes that code-owner requirement entirely.
Changes
.github/CODEOWNERSNote
If the goal is to keep code-owner rules for some paths but stop requiring foundation review specifically, let me know and I can scope the CODEOWNERS file down instead of removing it. Also note that if branch protection separately requires a minimum number of approving reviews, that setting is configured in GitHub repo settings (not in the repo) and would need to be adjusted there.