chore: update client-side JS SDK to @launchdarkly/js-client-sdk@4#38
Open
kinyoklion wants to merge 1 commit into
Open
chore: update client-side JS SDK to @launchdarkly/js-client-sdk@4#38kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
- Replace launchdarkly-js-client-sdk@3 with @launchdarkly/js-client-sdk@4 - Update client-side API from LDClient.initialize() to createClient()/start() - Move bootstrap option from createClient options to start() options - Remove unnecessary es6-promise and event-source-polyfill - Update Node.js engine requirement to >=18 Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the client-side JavaScript SDK from the legacy
launchdarkly-js-client-sdk@3to the current@launchdarkly/js-client-sdk@4.Changes:
launchdarkly-js-client-sdk@3CDN script with@launchdarkly/js-client-sdk@4ESM importLDClient.initialize()tocreateClient()+start()bootstrapoption fromcreateClient()options tostart()options (new SDK API)es6-promiseandevent-source-polyfillpolyfills16.13.1to>=18Tested locally — both normal and bootstrapped clients display flag values correctly with no console warnings.
Review & Testing Checklist for Human
npm install && npm startwith validLD_SDK_KEYandLD_CLIENTSIDE_IDand verify both normal and bootstrapped clients display flag valuesNotes
The server-side SDK (
@launchdarkly/node-server-sdk >= 8.0.0) was not changed — it already resolves to the latest version (9.11.0).Link to Devin session: https://app.devin.ai/sessions/b648d8cd5e0b4a04ba0cbf1dcd1a9886
Requested by: @kinyoklion