chore: major prettier update by yusinto · Pull Request #208 · launchdarkly/js-core

yusinto · 2023-07-19T22:16:48Z

This PR only contains config changes. The post-prettier-ran after effects are in #209 where all the CI checks are green.

Updated prettier to v3.0
Added prettier-plugin-sort-imports to sort imports

The main files to review are the root .prettierrc and root package.json. The other package.json updates are just mirrors of the root.

yusinto · 2023-07-19T22:19:01Z

+  "semi": false,
+  "plugins": ["@trivago/prettier-plugin-sort-imports"],
+  "importOrder": ["^@launchdarkly/(.*)$", "^[./]"],
+  "importOrderCaseInsensitive": true,
+  "importOrderSeparation": true,
+  "importOrderSortSpecifiers": true


I got rid of semicolons in other projects and I don't miss them. Let me know if you think they are necessary, I'm more than happy to negotiate.

Sorting imports make our code nicer and it's already part of gonfalon. We are using the prettier plugin here which is better and more modern, compared to the eslint plugin in gonfalon.

I strongly favor semicolons, but I think it is only personal preference. I don't have any reason to add them, and I don't think there is any reason to remove them either. So, I'm not going to stop you.

Thank you for the feedback. I have re-instated semicolons.

yusinto · 2023-07-19T22:19:59Z

    "contract-tests": "npm run contract-test-service & npm run contract-test-harness",
-    "prettier": "npx prettier --write \"**/*.{js,ts,tsx,json,yaml,yml,md}\" --loglevel warn"
+    "prettier": "npx prettier --write \"**/*.{js,ts,tsx,json,yaml,yml,md}\" --log-level warn",
+    "check": "yarn && yarn prettier && yarn lint && tsc && yarn build"


Added check as a quick way to validate everything still works. I included tsc to validate typescript and its json config files.

yusinto · 2023-07-19T22:20:41Z

+    "prettier": "^3.0.0",
    "typedoc": "0.23.26",
-    "typescript": "^4.6.3"
+    "typescript": "^5.1.6"


Worth pointing out major typescript update here. I don't think this is a big deal because all the other sub projects are already on v5.0.

yusinto · 2023-07-19T22:21:28Z

-    },
-    {
-      "path": "./packages/store/node-server-sdk-redis/tsconfig.ref.json"
-    },
-    {
-      "path": "./packages/store/node-server-sdk-dynamodb/tsconfig.ref.json"


yarn check revealed these don't exist, which is true so I deleted them.

Originally I had things compiling effectively as one large project. Now running tsc just double compiles some parts of it, because the build runs tsc on each thing in order. Because the builds had extra requirements like rollup.

yusinto · 2023-07-20T02:43:46Z

  },
  "peerDependencies": {
-    "@aws-sdk/client-dynamodb": "^3.53.0",
+    "@aws-sdk/client-dynamodb": "^3.370.0",


Callout here I had to update this because typescript was erroring. I suspect upgrading from ts 4 to 5 needs this updating.

We chose 53 for specific reasons, and if it doesn't work, then we should figure that out. If it cannot be resolved, then we should choose another version that isn't likely to inconvenience customers.

The peer dependency shouldn't have much of a bearing on if it works though. Things are compiled with the dev dependency. Currently it is the lowest to help maintain compatibility.

What is typescript error?

I rolled back these changes to reproduce the error but could not. As a result, I am not going to update the aws packages in this PR. I'll keep them the same as main.

…tly moving it

This PR is the result of running prettier v3 #208 on all files in the codebase. --------- Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com>

…AIC-2858) (#1794)  **Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's pull request submission guidelines - [x] I have validated my changes against all supported platform versions **Related issues** - [AIC-2858](https://launchdarkly.atlassian.net/browse/AIC-2858) — Make Changes to Node.js - Parent: [AIC-2849](https://launchdarkly.atlassian.net/browse/AIC-2849) — Add modelKey and modelVersion as fields to be read by SDK - Depends on backend payload work: [AIC-2876](https://launchdarkly.atlassian.net/browse/AIC-2876) - Mirrors Go: [AIC-2850](https://launchdarkly.atlassian.net/browse/AIC-2850) / Python: [PR #208](launchdarkly/python-server-sdk-ai#208) **Describe the solution you've provided** Read `modelKey` and `modelVersion` from the AI Config variation payload (`variation.model`) and stamp them on all `LDAIConfigTracker` metric event payloads, alongside existing `modelName`/`providerName` fields. - Add optional `modelKey`/`modelVersion` to `LDModelConfig` - Pass the new fields into `LDAIConfigTrackerImpl` from `LDAIClientImpl._evaluate` - Include `modelVersion` (always) and `modelKey` (when present) in `getTrackData()` - Default `modelVersion` to `1` when absent; exclude both fields from the resumption token - Additive/backward compatible — older payloads without the new fields continue to work **Describe alternatives you've considered** None — this mirrors the established pattern from the Go and Python SDK implementations. **Additional context** Tech spec: [Models Primitive Improvements](https://launchdarkly.atlassian.net/wiki/spaces/PD/pages/4977984384/Models+Primitive+Improvements+-+Tech+Spec) ## Test plan - [x] `yarn workspace @launchdarkly/server-sdk-ai test` (241 passed) - [x] `yarn workspace @launchdarkly/server-sdk-ai lint` - [x] `yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/server-sdk-ai' run build` - [ ] Verify against a staging environment once AIC-2876 payload is available  <div><a href="https://cursor.com/agents/bc-cf6a4de0-cf19-4491-b781-9b617da9a68d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-cf6a4de0-cf19-4491-b781-9b617da9a68d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> [AIC-2858]: https://launchdarkly.atlassian.net/browse/AIC-2858?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AIC-2849]: https://launchdarkly.atlassian.net/browse/AIC-2849?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AIC-2876]: https://launchdarkly.atlassian.net/browse/AIC-2876?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AIC-2850]: https://launchdarkly.atlassian.net/browse/AIC-2850?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Anthony Torns II <atornsii@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

yusinto added 4 commits July 19, 2023 14:46

chore: update deps

5c95dc7

chore: added tsc to check command

d568493

chore: updated all package.jsons

a6cb7dc

fix: delete invalid files

1925d6e

yusinto requested review from kinyoklion and louis-launchdarkly as code owners July 19, 2023 22:16

yusinto commented Jul 19, 2023

View reviewed changes

yusinto mentioned this pull request Jul 19, 2023

chore: file changes after prettier update #209

Merged

yusinto added 2 commits July 19, 2023 15:46

chore: update other project deps

cec76f6

chore: update aws dep to fix ts errors

aa46498

yusinto commented Jul 20, 2023

View reviewed changes

yusinto and others added 7 commits July 21, 2023 12:12

chore: reinstated semicolons

f79c486

fix: rollback aws dynamo version

e1ed9c1

Update .prettierignore

906c143

fix: exclude edgekv.js because it is an external file

e0cec42

fix: moved comments to function level to avoid prettier from incorrec…

72a1af7

…tly moving it

chore: file changes after prettier update (#209)

1e46326

This PR is the result of running prettier v3 #208 on all files in the codebase. --------- Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com>

Merge branch 'main' into yus/prettier-changes

6c5b8b6

kinyoklion approved these changes Jul 28, 2023

View reviewed changes

yusinto merged commit 4a14933 into main Jul 28, 2023

yusinto deleted the yus/prettier-changes branch July 28, 2023 23:18

Navigation Menu

Uh oh!

chore: major prettier update - #208

chore: major prettier update#208
yusinto merged 13 commits into
mainfrom
yus/prettier-changes

yusinto commented Jul 19, 2023 •

edited

Loading

Uh oh!

yusinto Jul 19, 2023

Uh oh!

kinyoklion Jul 21, 2023

Uh oh!

yusinto Jul 21, 2023

Uh oh!

yusinto Jul 19, 2023

Uh oh!

yusinto Jul 19, 2023

Uh oh!

yusinto Jul 19, 2023

Uh oh!

kinyoklion Jul 28, 2023

Uh oh!

yusinto Jul 20, 2023

Uh oh!

kinyoklion Jul 21, 2023

Uh oh!

yusinto Jul 21, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yusinto commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yusinto Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yusinto commented Jul 19, 2023 •

edited

Loading

yusinto Jul 21, 2023 •

edited

Loading