Adding get project by project key#328
Merged
Merged
Conversation
mike-zorn
reviewed
Jun 25, 2024
| // Package api provides primitives to interact with the openapi HTTP API. | ||
| // | ||
| // Code generated by github.com/oapi-codegen/oapi-codegen/v2 version v2.3.0 DO NOT EDIT. | ||
| // Code generated by github.com/deepmap/oapi-codegen version v1.16.3 DO NOT EDIT. |
There was a problem hiding this comment.
hmmmm how did you install the code generator? It looks like somehow you're using an old version.
Author
There was a problem hiding this comment.
🤦 I thought I just did a go install but I had so many weird things going on locally. Let me fix this.
There was a problem hiding this comment.
Oh the docs are kinda not great because they first tell you how to install the deprecated version. Try go install github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@latest
mike-zorn
reviewed
Jun 25, 2024
| r.Use(model.StoreMiddleware(sqlStore)) | ||
| // TODO need a subrouter for relay endpoints | ||
| handler := api.HandlerFromMux(apiServer, r) | ||
| fmt.Println("Server running on 0.0.0.0:8765") |
mike-zorn
reviewed
Jun 25, 2024
mike-zorn
left a comment
mike-zorn
left a comment
There was a problem hiding this comment.
api yaml format changes are fine. Let's get the tool version figured out before you merge though.
mike-zorn
approved these changes
Jun 25, 2024
mike-zorn
left a comment
mike-zorn
left a comment
There was a problem hiding this comment.
approving, assuming we get the tool version straight.
ld-kyee
force-pushed
the
kmartinez/moonshot-ld-server
branch
from
3d72c6c to
d9fafa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unclear why there were so many formatting changes in the api.yaml file.