-
Notifications
You must be signed in to change notification settings - Fork 13
fix(deps): use consistent Go version in builds and CI #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| latest=1.22.1 | ||
| penultimate=1.21.8 | ||
| latest=1.22.5 | ||
| penultimate=1.21.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # The following chunk of yml boils down to pulling two Go version numbers out of a file and | ||
| # making them available to the other workflows in a convenient fashion. | ||
| # | ||
| # It's a reusable workflow instead of an action so that its output can be used in a matrix strategy | ||
| # of another job. | ||
| # | ||
| # The idea is to define the most recent, and penultimate, Go versions that should be used to test Relay. | ||
| # Ideally we'd define these in a single place - otherwise we'd need to update many different places in | ||
| # each workflow. This single place is .github/variables/go-versions.env. | ||
| # | ||
| # This reusable workflow grabs them out of the file, then sets them as outputs. As a convenience, it | ||
| # also wraps each version in an array, so it can be directly used in a matrix strategy. Single-item matrices | ||
| # are nice because you can tell instantly in the Github UI which version is being tested without needing | ||
| # to inspect logs. | ||
| # | ||
| # To use a matrix output, e.g. latest version, do: | ||
| # strategy: | ||
| # matrix: ${{ fromJSON(this-job.outputs.latest-matrix) }} | ||
| # | ||
| name: Go Versions | ||
| on: | ||
| workflow_call: | ||
| outputs: | ||
| latest: | ||
| description: 'The most recent Go version to test' | ||
| value: ${{ jobs.go-versions.outputs.latest }} | ||
| penultimate: | ||
| description: 'The second most recent Go version to test' | ||
| value: ${{ jobs.go-versions.outputs.penultimate }} | ||
| matrix: | ||
| description: 'All Go versions to test as a matrix' | ||
| value: ${{ jobs.go-versions.outputs.all }} | ||
|
|
||
| jobs: | ||
| go-versions: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| latest: ${{ steps.set-env.outputs.latest }} | ||
| penultimate: ${{ steps.set-env.outputs.penultimate }} | ||
| all: ${{ steps.set-matrix.outputs.all }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set Go Versions | ||
| id: set-env | ||
| run: cat ./.github/variables/go-versions.env > $GITHUB_OUTPUT | ||
| - name: Set Go Version Matrices | ||
| id: set-matrix | ||
| run: | | ||
| echo "all=[\"${{ steps.set-env.outputs.latest }}\",\"${{ steps.set-env.outputs.penultimate }}\"]" >> $GITHUB_OUTPUT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module github.com/launchdarkly/ldcli | ||
|
|
||
| go 1.20 | ||
| go 1.21 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although it's not strictly true that we require 1.21, since we're building with 1.21 and 1.22 we can't claim this. See my other comment for an alternative. |
||
|
|
||
| require ( | ||
| github.com/charmbracelet/bubbles v0.18.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This whole file is copied from Relay. It'd be nice to make it reusable.. but not sure it's worth it yet.)