Skip to content

fix: Remove stutter from "fetching {sdk name} SDK SDK" #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbolson merged 2 commits into from
Aug 14, 2024
Merged

fix: Remove stutter from "fetching {sdk name} SDK SDK" #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0af7fc
Remove stutter from "fetching {sdk name} SDK SDK"
Aug 13, 2024
637a593
Fix formatting
Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/quickstart/show_sdk_instructions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package quickstart

import (
"fmt"
"github.com/launchdarkly/sdk-meta/api/sdkmeta"

"github.com/charmbracelet/bubbles/help"
"github.com/charmbracelet/bubbles/key"
Expand All @@ -11,6 +10,7 @@ import (
tea "github.com/charmbracelet/bubbletea"
"github.com/charmbracelet/glamour"
"github.com/charmbracelet/lipgloss"
"github.com/launchdarkly/sdk-meta/api/sdkmeta"

"github.com/launchdarkly/ldcli/internal/environments"
"github.com/launchdarkly/ldcli/internal/flags"
Expand Down Expand Up @@ -156,7 +156,7 @@ func (m showSDKInstructionsModel) View() string {
}

if m.instructions == "" || m.environment == nil {
return m.spinner.View() + fmt.Sprintf(" Fetching %s SDK instructions...\n", m.displayName) + footerView(m.help.View(m.helpKeys), nil)
Copy link
Copy Markdown
Contributor

@cwaldren-ld cwaldren-ld Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, I caught the one in the quickstart title but not this.

Copy link
Copy Markdown
Contributor Author

@dbolson dbolson Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bummer we don't have tests for the setup UI to catch stuff like this.

return m.spinner.View() + fmt.Sprintf(" Fetching %s instructions...\n", m.displayName) + footerView(m.help.View(m.helpKeys), nil)
}

m.help.ShowAll = true
Expand Down