Skip to content

feat: Add pagination, search, styling changes. #419

Merged
cdelst merged 2 commits into
mikezorn/sc-254693/validate-overrides-against-what-s-in-thefrom
cdelst/sc-255193/virtualize-the-flags-list-with-a-search-bar
Sep 5, 2024
Merged

feat: Add pagination, search, styling changes. #419
cdelst merged 2 commits into
mikezorn/sc-254693/validate-overrides-against-what-s-in-thefrom
cdelst/sc-255193/virtualize-the-flags-list-with-a-search-bar

Conversation

@cdelst
Copy link
Copy Markdown
Contributor

@cdelst cdelst commented Sep 4, 2024

This PR fixes some performance concerns by adding pagination and fuzzy search.

It also adds some styling changes to make a consistent UI experience.

It also adds dark mode/light mode support based on browser setting.

image

image

@cdelst cdelst requested a review from mike-zorn September 4, 2024 22:58
@cdelst cdelst changed the title Add pagination, search, styling changes. feat: Add pagination, search, styling changes. Sep 4, 2024
Comment thread internal/dev_server/ui/src/App.css Outdated
Comment thread internal/dev_server/ui/src/App.css Outdated
Comment thread internal/dev_server/ui/src/App.css Outdated
Comment thread internal/dev_server/ui/src/Flag.tsx Outdated
Comment thread internal/dev_server/ui/src/Flags.tsx Outdated
Comment thread internal/dev_server/ui/src/Flags.tsx
@cdelst cdelst requested a review from mike-zorn September 5, 2024 18:37
@cdelst cdelst merged commit ac91ec3 into mikezorn/sc-254693/validate-overrides-against-what-s-in-the Sep 5, 2024
@cdelst cdelst deleted the cdelst/sc-255193/virtualize-the-flags-list-with-a-search-bar branch September 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants