Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/setup/flag_toggle.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (m flagToggleModel) View() string {
margin := 1
if m.enabled {
bgColor = "#3d9c51"
furtherInstructions = "\n\nCheck your [browser|application logs] to see the change!"
furtherInstructions = "\n\nCheck your [browser|application logs] to see the change."
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowered the volume on this because there's an exclamation above.

margin = 2
toggle = "ON"
}
Expand Down
10 changes: 6 additions & 4 deletions internal/setup/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package setup

import (
"fmt"

"github.com/charmbracelet/bubbles/key"
"github.com/charmbracelet/bubbles/list"
"github.com/charmbracelet/bubbles/textinput"
Expand All @@ -27,7 +28,6 @@ func (p flag) FilterValue() string { return "" }

type flagModel struct {
input string
err error
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused.

textInput textinput.Model
}

Expand Down Expand Up @@ -69,9 +69,11 @@ func (m flagModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
}

func (m flagModel) View() string {
style := lipgloss.NewStyle().
MarginLeft(2)

return fmt.Sprintf(
"Name your first feature flag (enter for default value):\n\n%s\n\n%s",
m.textInput.View(),
"(esc to quit)",
"Name your first feature flag (enter for default value):\n\n%s",
style.Render(m.textInput.View()),
) + "\n"
}
7 changes: 5 additions & 2 deletions internal/setup/sdk_instructions.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

tea "github.com/charmbracelet/bubbletea"
"github.com/charmbracelet/glamour"
"github.com/charmbracelet/lipgloss"
"github.com/muesli/reflow/wordwrap"
)

Expand All @@ -30,11 +31,13 @@ func (m sdkInstructionModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
}

func (m sdkInstructionModel) View() string {
style := lipgloss.NewStyle().Border(lipgloss.NormalBorder())
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a border around the instructions like in the screenshots.


return wordwrap.String(
fmt.Sprintf(
"Set up your application. Here are the steps to incorporate the LaunchDarkly %s SDK into your code. \n\n%s",
"Set up your application. Here are the steps to incorporate the LaunchDarkly %s SDK into your code.\n%s",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed an extra newline.

m.name,
m.renderMarkdown(),
style.Render(m.renderMarkdown()),
),
m.width,
)
Expand Down
14 changes: 8 additions & 6 deletions internal/setup/sdks.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ type sdk struct {
func (s sdk) FilterValue() string { return "" }

type sdkModel struct {
choice sdk
instructions string
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused.

err error
list list.Model
choice sdk
list list.Model
}

const sdkInstructionsFilePath = "internal/setup/sdk_build_instructions/"
Expand Down Expand Up @@ -75,7 +73,11 @@ func NewSdk() tea.Model {
}

l := list.New(sdksToItems(sdks), sdkDelegate{}, 30, 14)
l.Title = "Select your SDK."
l.Title = "Select your SDK:\n"
// reset title styles
l.Styles.Title = lipgloss.NewStyle()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These get default styles set on then from list.New, so we need to remove them.

l.Styles.TitleBar = lipgloss.NewStyle()
l.SetShowPagination(true)
l.SetShowStatusBar(false)
l.SetFilteringEnabled(false)
l.Paginator.PerPage = 5
Expand Down Expand Up @@ -111,7 +113,7 @@ func (m sdkModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
}

func (m sdkModel) View() string {
return "\n" + m.list.View()
return m.list.View()
}

type sdkDelegate struct{}
Expand Down
2 changes: 1 addition & 1 deletion internal/setup/wizard.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (m WizardModel) View() string {
return fmt.Sprintf("ERROR: %s", m.err)
}

return fmt.Sprintf("\nstep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps))
return fmt.Sprintf("\nStep %d of %d\n"+m.steps[m.currStep].View(), m.currStep+1, len(m.steps))
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalized.

}

type keyMap struct {
Expand Down