feat: Add command for uploading frontend sourcemaps [OB-143]#531
Merged
Conversation
Contributor
Author
|
Original prompt from vkorolik@launchdarkly.com: |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Vadman97
reviewed
May 21, 2025
mmrj
reviewed
May 22, 2025
Contributor
mike-zorn
reviewed
May 24, 2025
mike-zorn
reviewed
May 24, 2025
mike-zorn
reviewed
May 24, 2025
|
Aside @Vadman97 I made some suggestions that caused code changes. I think it's good to merge, but you'll need to re-test |
Vadman97
approved these changes
May 27, 2025
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
…m package Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
…tly in Go Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Contributor
|
addressing feedback raised in https://github.com/launchdarkly/observability/pull/71 to make the authentication strategy more robust (forwarding the access token to highlight to perform the authentication there. let me know if there are any concerns with this approach. |
d30e64a to
a891dec
Compare
Co-Authored-By: vkorolik@launchdarkly.com <vkorolik@gmail.com>
Contributor
|
validated with changes from https://github.com/launchdarkly/observability/pull/71
|
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add sourcemaps command for uploading frontend sourcemaps
This PR adds a new
sourcemapscommand to the LaunchDarkly CLI for uploading JavaScript sourcemaps to LaunchDarkly for error monitoring. The implementation is based on the existing sourcemap uploader in theobservability-sdkrepository.Implementation Details
sourcemapscommand with anuploadsubcommand--api-key(required): The LaunchDarkly Observability API key--app-version: The current version of your deploy--path: Sets the directory of where the sourcemaps are (defaults to current directory)--base-path: An optional base path for the uploaded sourcemaps--backend-url: An optional backend url for self-hosted deploymentsFeatures
.js.mapfiles in the specified directorynode_modulesdirectories when searching for sourcemapsTesting
Link to Devin run
https://app.devin.ai/sessions/11aee1380731458dacd92573c687372f
Requested by: vkorolik@launchdarkly.com
Related Jira issue: O11Y-5: create a ldcli sourcemap uploader command