Skip to content

fix: rebind projKey flag to update subcommand #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k3llymariee merged 2 commits into from
Mar 25, 2024
Merged

fix: rebind projKey flag to update subcommand #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d0f0d
rebind projKey flag to update subcommand
Mar 25, 2024
2c3ed8e
bind projKey flag to create flag also
Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/flags/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ func runCreate(cmd *cobra.Command, args []string) error {
viper.GetString("baseUri"),
)

// rebind flag to this subcommand
viper.BindPFlag("projKey", cmd.Flags().Lookup("projKey"))

var data inputData
err := json.Unmarshal([]byte(cmd.Flags().Lookup("data").Value.String()), &data)
// err := json.Unmarshal([]byte(viper.GetString("data")), &data)
Expand Down
3 changes: 3 additions & 0 deletions cmd/flags/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ func runUpdate(cmd *cobra.Command, args []string) error {
viper.GetString("baseUri"),
)

// rebind flag to this subcommand
viper.BindPFlag("projKey", cmd.Flags().Lookup("projKey"))
Copy link
Copy Markdown

@sunnyguduru sunnyguduru Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we basically rebinding it before we pass the data in?

Copy link
Copy Markdown

@sunnyguduru sunnyguduru Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess somewhere in the issue you linked I saw that since these are "local flags" for a subcommand they get overwritten

Copy link
Copy Markdown

@sunnyguduru sunnyguduru Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a helper function that rebinds all the flags were going to use/re-use or something since we're going to have a lot of subcommands.


var patch []ldapi.PatchOperation
// err := json.Unmarshal([]byte(viper.GetString("data")), &patch)
err := json.Unmarshal([]byte(cmd.Flags().Lookup("data").Value.String()), &patch)
Expand Down