Skip to content

ci: prevent script injection in manual-publish-docs workflow #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkaeding merged 1 commit into from
Aug 7, 2026
+16 −6
Merged

ci: prevent script injection in manual-publish-docs workflow #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/manual-publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,21 @@ jobs:

- name: Check if JS package
id: check-js-package
env:
WORKSPACE_PATH: ${{ inputs.workspace_path }}
run: |
if ./scripts/is-js-package.sh ${{ inputs.workspace_path }}; then
if ./scripts/is-js-package.sh "$WORKSPACE_PATH"; then
echo "is_js_package=true" >> $GITHUB_OUTPUT
else
echo "is_js_package=false" >> $GITHUB_OUTPUT
fi

- name: Check if python package
id: check-python-package
env:
WORKSPACE_PATH: ${{ inputs.workspace_path }}
run: |
if ./scripts/is-python-package.sh ${{ inputs.workspace_path }}; then
if ./scripts/is-python-package.sh "$WORKSPACE_PATH"; then
echo "is_python_package=true" >> $GITHUB_OUTPUT
else
echo "is_python_package=false" >> $GITHUB_OUTPUT
Expand All @@ -66,13 +70,15 @@ jobs:
- name: 'Set WORKSPACE_NAME variable'
if: ${{ steps.check-js-package.outputs.is_js_package == 'true' }}
shell: bash
env:
WORKSPACE_PATH: ${{ inputs.workspace_path }}
run: |
WORKSPACE_NAME=$(./scripts/package-name.sh ${{ inputs.workspace_path }})
WORKSPACE_NAME=$(./scripts/package-name.sh "$WORKSPACE_PATH")
echo "WORKSPACE_NAME=$WORKSPACE_NAME" >> $GITHUB_ENV

- name: Build JS package docs
if: ${{ steps.check-js-package.outputs.is_js_package == 'true' }}
run: yarn docs --filter ${{ env.WORKSPACE_NAME }}
run: yarn docs --filter "$WORKSPACE_NAME"

- uses: actions/setup-python@v5
if: ${{ steps.check-python-package.outputs.is_python_package == 'true' }}
Expand All @@ -87,15 +93,19 @@ jobs:
# Assume non-js projects will use a Makefile to install dependencies.
# Or an empty install target.
if: ${{ steps.check-js-package.outputs.is_js_package == 'false' }}
env:
WORKSPACE_PATH: ${{ inputs.workspace_path }}
run: |
cd ${{ inputs.workspace_path }}
cd "$WORKSPACE_PATH"
make install

- name: Build Makefile Docs
# Assume non-js projects will use a Makefile to build docs.
if: ${{ steps.check-js-package.outputs.is_js_package == 'false' }}
env:
WORKSPACE_PATH: ${{ inputs.workspace_path }}
run: |
cd ${{ inputs.workspace_path }}
cd "$WORKSPACE_PATH"
make docs

- name: Publish Highlight.run as Observability Plugin
Expand Down
Loading