chore: pin third-party GitHub Actions to commit SHAs#374
Merged
Conversation
Pin all third-party GitHub Actions to full-length commit SHAs to prevent supply chain attacks. Addresses findings from the third-party-action-not-pinned-to-commit-sha Semgrep rule.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
keelerm84
reviewed
Mar 24, 2026
keelerm84
reviewed
Mar 24, 2026
Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com>
keelerm84
approved these changes
Mar 24, 2026
2 tasks
kinyoklion
added a commit
to launchdarkly/openfeature-ruby-server
that referenced
this pull request
Mar 30, 2026
## Summary Pin all third-party GitHub Actions to full-length commit SHAs to prevent supply chain attacks. Addresses findings from the [`third-party-action-not-pinned-to-commit-sha`](https://github.com/launchdarkly/semgrep-rules/blob/main/github-actions/third-party-action-not-pinned-to-commit-sha.yml) Semgrep rule. ### Updates since initial revision - Version comments now use fully qualified version numbers (e.g. `# v4.4.0` instead of `# v4`) - `ruby/setup-ruby` bumped from v1.295.0 (`319994f...`) to **v1.299.0** (`3ff19f5e2baf30647122352b96108b1fbe250c64`), the latest v1 release - `googleapis/release-please-action` confirmed at **v4.4.0** (`16a9c90856f42705d54a6fda1823352bdc62cf38`), already the latest v4 release Release links for verification: - [ruby/setup-ruby v1.299.0](https://github.com/ruby/setup-ruby/releases/tag/v1.299.0) - [googleapis/release-please-action v4.4.0](https://github.com/googleapis/release-please-action/releases/tag/v4.4.0) ## Review & Testing Checklist for Human - [ ] Verify the pinned SHAs match the expected release tags using the release links above - [ ] Confirm CI passes with the updated `ruby/setup-ruby` v1.299.0 (bumped from v1.295.0) ### Notes - The `slsa-framework/slsa-github-generator` reference on line 61 of `release-please.yml` remains at `@v2.0.0` (floating tag) — this action [cannot be pinned to a commit SHA](launchdarkly/ruby-server-sdk#374 (comment)). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: changes only pin GitHub Action references to specific commits, with no functional logic changes beyond potential action version drift if the pinned SHAs differ from the floating tags. > > **Overview** > Pins third-party GitHub Actions to immutable commit SHAs to harden CI/release workflows against supply-chain tampering. > > Updates `ruby/setup-ruby@v1` usages (composite CI action, Windows CI job, and docs publish workflow) to a specific commit SHA, and similarly pins `googleapis/release-please-action@v4` in the release workflow to a specific `v4.4.0` commit. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 12e5cd3. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Link to Devin session: https://app.devin.ai/sessions/56bd3c6eff084ef4802aaa48b08ebab6 Requested by: @kinyoklion --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Pin all third-party GitHub Actions to full-length commit SHAs to prevent supply chain attacks.
Addresses findings from the
third-party-action-not-pinned-to-commit-shaSemgrep rule.Test plan
Note
Low Risk
Low risk: this only pins external GitHub Actions to specific commit SHAs; the main risk is CI behavior changing if the pinned revisions differ from the previously floating tags.
Overview
Pins third-party GitHub Actions to immutable commit SHAs for supply-chain hardening.
Updates
ruby/setup-rubyin the composite setup action andgoogleapis/release-please-actionin the release workflow to use full commit hashes (with version comments) instead of floating version tags.Written by Cursor Bugbot for commit 7f70e34. This will update automatically on new commits. Configure here.