support keyboardLayoutGuide#238
Conversation
lucdion
left a comment
lucdion
left a comment
There was a problem hiding this comment.
Thanks for this addition. Could you please document this new property in the section https://github.com/layoutBox/PinLayout#safearea-readable-and-layout-margins 🙏
|
Oh? |
| } | ||
|
|
||
| #if os(iOS) | ||
| public var keyboardLayout: PEdgeInsets { |
There was a problem hiding this comment.
After more thinking, it would better match other properties if we would name it keyboardMargins
UIView.readableContentGuideis namedpin.readableMarginsUIView.layoutMarginsGuideis namedpin.layoutMargins
Then I would propose
UIView.keyboardLayoutGuidenamedpin.keyboardMargins
What do you think?
|
"value of type 'UIView' has no member 'keyboardLayoutGuide'".? |
|
Umm... Is it because of the version? |
|
This is strange because Travis is using So this should work. Does it compiles correctly on your system? |
|
Looking at Travis, I think the version of Xcode is 12.5. Looking at build-ci.sh, I think the version of OS is 14.5. Could you check it again? |
|
Oups, sorry, I forget to open the PR. Locally I had those modifications. I just opened this PR #239 |
|
Phew |
|
OK, I have merged #239, you can update your branch. |
|
🛌 |
| apply() | ||
| } | ||
|
|
||
| #if os(iOS) |
There was a problem hiding this comment.
Detail, but you could move this block just below public var layoutMargins: PEdgeInsets, so the proprities are declared from the most useful property order? Thanks
lucdion
left a comment
lucdion
left a comment
There was a problem hiding this comment.
Excellent. Thanks for the addition 👍
|
New release including your change https://github.com/layoutBox/PinLayout/releases/tag/1.10.1 |
2 participants
No description provided.